Skip to content

Conversation

@omsuneri
Copy link
Member

check if the workflow for test works properly or not

@omsuneri
Copy link
Member Author

@walterbender we need to add the PAT in the secrets and variable of the action workflow
cause still after merging the workflow the comment is not coming on the PR also once adding the PAT secret we can simply use that in all the workflows it improves the workflow as for example the test workflow works in the following manner

  1. it merge the PR in some hypothetical branch and assume it as master
  2. then it run all the tests over that branch
  3. if tests pass it put positive comment and hereby the workflow is successful
  4. else if tests fails it put negative comment on the PR and hereby still the workflow is successful

so when you simply view the workflow passes or not you cannot detect if the test run is failed or not so getting the comment is the only way we can detect the exact error in the test files reduces the reviwer's work.
also it reduces teh time to debug the error in the test cases.

so for PAT you need to add the token code after generating from github in to our musicblocks repo secrets and variables of action section (which i m unable to access as due to write access issues) any admin can do this.
What are your suggestions over this ??

@omsuneri omsuneri closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant