removed clear confirmation during load project #4153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
skipConfirmation = true when the confirmation skipped. In doLoad() function it is skipped. |
Contributor
Author
|
@walterbender Sir, please review the PR |
Contributor
Author
|
@walterbender Sir is this okay or something changes required ? |
This was referenced Dec 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #4152
In Musicblocks when we try to load an existing project by clicking "Load project from file" from our system an unwanted clear confirmation happens because the doLoad() function internally called the _allClear() function so that due to _allClear() the unwanted confirmation happened. But now it is removed.
Reason
here the doLoad() function called _allClear() function by passing true argument. So that internally canvas is going to clear. But we don't want that while loading an existing project because we are sure about to do it.
So I pass an extra default argument which determine when the confirmation will skip. When the parameter is true the confirmation is skipped otherwise not.
But the other calling of _allClear() it has no such parameter so that it will not effect those calling because we don't pass anything by default as it is previously.
Current Behaviour
Screen.Recording.2024-12-18.101736.mp4