Skip to content

Conversation

@apsinghdev
Copy link
Contributor

addresses: #4124

Issues: #4145 (comment)

Screenshot 2024-12-15 at 12 32 40 AM

In this PR I have removed the configurations that we don't need for now and added jest as devDependency to streamline the workflow of adding tests in MB.

After this, tests are working properly without throwing error or creating extra files.

Screenshot 2024-12-15 at 1 14 52 AM

@apsinghdev apsinghdev changed the title Fix/add jest fix: add jest dependency and remove extra configs from jest.config.js Dec 14, 2024
@apsinghdev
Copy link
Contributor Author

@walterbender Please have a look.

@omsuneri
Copy link
Member

@apsinghdev actually to build test for platform style I require to add some more configuration that's why I had added those configuration.

@apsinghdev
Copy link
Contributor Author

@apsinghdev actually to build test for platform style I require to add some more configuration that's why I had added those configuration.

Can you please list down the configuration you need for platformstyle and reasoning behind it?

@omsuneri
Copy link
Member

@apsinghdev i need the test enviorment jsdom to simulate a browser environment

@apsinghdev
Copy link
Contributor Author

@walterbender As we discussed in the last meeting, I guess, we are on the same ground regarding not adding dom env for now. So this PR is ready for review.

@walterbender
Copy link
Member

Yes... until sort out the dependencies we'll need.

@apsinghdev
Copy link
Contributor Author

Yes... until sort out the dependencies we'll need.

Oops! I forgot that. I'll write an issue for it. :)

@walterbender walterbender merged commit 8be6d50 into sugarlabs:master Dec 19, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants