Skip to content

Conversation

@subhas-pramanik-09
Copy link
Contributor

Resolves issue #4135
For PR #4138

Now Musicblocks has notification for enabling or disabling horizontal scrolling

As the PR #4138 has unwanted changes so I updated it through this PR

Screen.Recording.2024-12-13.172948.mp4

@subhas-pramanik-09
Copy link
Contributor Author

subhas-pramanik-09 commented Dec 14, 2024

@walterbender Sir, as you said in PR #4138 to remove unwanted changes. I updated this it in this PR. now this PR has only changes regarding this.

Please review it.

@subhas-pramanik-09
Copy link
Contributor Author

yes sir I added spaces

@subhas-pramanik-09
Copy link
Contributor Author

Sorry for too many commits. Please check it Sir

js/activity.js Outdated
else if (ele.label === "Disable horizontal scrolling")
ele.display = false;
})
activity.textMsg(_("Horizontal scrolling disabled."),3000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@walterbender walterbender merged commit bfb52c5 into sugarlabs:master Dec 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants