Made musicutils.test.js #4124 #4140
Conversation
| }); | ||
| }); | ||
| }); | ||
| /* |
There was a problem hiding this comment.
Curious why this commented code is included?
There was a problem hiding this comment.
When I made test functions for the "Temperament Management " block the results were not matched. Somehow the functions are not working.
I did not want to edit musicutil.js so I left this job to @Aman1919
There was a problem hiding this comment.
Then please remove the commented code from this PR.
There was a problem hiding this comment.
@walterbender this shows error while running the test
|
@Commanderk3 i think if you guyss are collaborting then make a draft PR as this might not confused the others to create a test and i had created a config and setup file for jest kindly use those two files to make sure the setup works fine with every test @walterbender can you review it again |
|
I tested and saw no error. Maybe since your new files were added? I'll check again. |
|
It seems the same for me too @walterbender I ll make it correct if it happens with my files |
|
@omsuneri your commit introduced the error on my system. |
|
Okay @walterbender I ll correct the test file |
3 participants
This PR brings the initialization of musicutils.test.js
It contains about 67 tests and covers 14 functions from musicutils.js
The rest of the portion will be done by @Aman1919 and @BeNikk as we are collaborating on this.
I had to paste the base64Encode function in musicutils.js (copied from base64Utils.js) . The base64Utils file uses a different export syntax than the rest (probably ES Module) therefor importing it caused some errors.
@walterbender Sir, kindy check this PR.