-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closing of popup message for quick action #4095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing of popup message for quick action #4095
Conversation
|
@walterbender Sir please check it. |
|
@walterbender Sir is it okay ..or i have to change something |
|
@pikurasa what do you think of this? It will impact all messages, not just trash messages. |
index.html
Outdated
| printText.classList.remove("show"); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these spaces here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir i have removed the extra spaces. please check
it will impact for all messages....like this Screen.Recording.2024-12-04.220513.mp4 |
|
@walterbender @pikurasa Sir is this approach correct ? |
I need to think about this. I've been in favor of this for closing menus, but I hadn't really thought of messages that much. I guess my only initial concern is that eager kids may accidentally close important messages without a chance to read them (or for a teacher to read them). |
|
I think we should hold off on this change. |
Current Behavior
As per the issue #4094 now user can close the popup message that appears after moving a block in trash not only the cross button as well as anywhere in the canvas. So user can take next action very quickly. It improves the user experience.
Screen Record
Screen.Recording.2024-12-04.024159.mp4