Skip to content

Conversation

@subhas-pramanik-09
Copy link
Contributor

Current Behavior

As per the issue #4094 now user can close the popup message that appears after moving a block in trash not only the cross button as well as anywhere in the canvas. So user can take next action very quickly. It improves the user experience.

Screen Record

Screen.Recording.2024-12-04.024159.mp4

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir please check it.

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir is it okay ..or i have to change something

@walterbender
Copy link
Member

@pikurasa what do you think of this? It will impact all messages, not just trash messages.

index.html Outdated
printText.classList.remove("show");
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these spaces here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir i have removed the extra spaces. please check

@subhas-pramanik-09
Copy link
Contributor Author

@pikurasa what do you think of this? It will impact all messages, not just trash messages.

it will impact for all messages....like this

Screen.Recording.2024-12-04.220513.mp4

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender @pikurasa Sir is this approach correct ?

@pikurasa
Copy link
Collaborator

pikurasa commented Dec 5, 2024

@pikurasa what do you think of this? It will impact all messages, not just trash messages.

I need to think about this. I've been in favor of this for closing menus, but I hadn't really thought of messages that much. I guess my only initial concern is that eager kids may accidentally close important messages without a chance to read them (or for a teacher to read them).

@walterbender
Copy link
Member

I think we should hold off on this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants