FIX #4074 , #2618 Fixed doSearch Race condition of improper loading, Fixed Minor another syntax error #4088
Conversation
Changes Made- Added logic to handle non-negative pickup values and support "faux pickups" like 1/3. Ensured notationPickup is called after setting the pickup value. Validated the pickup value before passing it to MeterActions.setPickup to prevent errors. Added input validation for pickup values in flow, ensuring only valid values are processed.
… better error handling
1. made the updatePluginObj code shorter and combined categories making it easier to maintain in the long term, also ensured that the structure exists 2. minor improvements in mixedNumber function
|
How did you test this? MB doesn't load on Firefox with these changes. |
|
I opened the MB software on chrome and edge and all the functions including related to search were working fine and the console only showed errors and warnings unrelated to this PR, I just now tested in firefox also and for me the MB software is functioning in firefox also. Can you provide any kind of errors or warnings that you might be receiving on firefox? because I double checked and MB is working fine. |
|
With your latest changes, I could get it to run on Firefox, but the search functionality itself is not working. Nothing in the log. |
|
Sorry for the delay, Yes i can see that the search functionality works only once and dosent work again and it sometimes works and sometimes does not i am trying to fix it but if i fix one issue a new one arises hence, i am looking into it |
|
Any progress on this? |
|
yes i tried many different approaches but all most of them seem to come with its own set of bugs and problems so have been unable to get to the roots of it and fix it and also i cant seem to find any help regarding that. Any sort of input would be grateful |
|
@arth-1 perhaps you can join us in our Matrix chat and ask questions there. We're at https://matrix.to/#/#musicblocksdev:matrix.org We also have weekly meetings, which you can read about in the topic for that room. |
|
no activity, failing tests. closing |
4 participants
doSearch was being loaded in incorrect order, hence fixing that by making sure that it is preloaded correctly making sure that the rest of the program does not cause errors.
Also fixed a syntax error where this.blocks was being not defined leading to the software not working.