feat: add live waveform visualization to sampler #4040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good. |
Contributor
Author
|
@walterbender Can you please review this. |
js/utils/synthutils.js
Outdated
| * @function | ||
| * @memberof Synth | ||
| */ | ||
| this.getValues = () => { |
Member
There was a problem hiding this comment.
maybe rename this function to reflect that it is getting values from the analyser?
js/widgets/sampler.js
Outdated
| canvasCtx.fillText(_("reference tone"), 10, 10); | ||
| canvasCtx.fillText(oscText, 10, canvas.height / 2 + 10); | ||
|
|
||
Member
There was a problem hiding this comment.
please, no spaces on otherwise empty lines.
Contributor
Author
There was a problem hiding this comment.
removed extra spaces
js/widgets/sampler.js
Outdated
| */ | ||
| function displayRecordingStartMessage() { | ||
| this.displayRecordingStartMessage = function () { | ||
| this.activity.textMsg(_("Recording started...")); |
Contributor
Author
|
@walterbender Can you please review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4005