Skip to content

Conversation

@mohitvdx
Copy link

@mohitvdx mohitvdx commented Feb 4, 2024

docker compose up -d command was not running properly due to wrong .env file path given in the docker-compose.yml

now the Project is easily setup by using the docker compose up -d command as given in the development docs
https://github.com/sugarlabs/musicblocks-v4/blob/develop/docs/DEV.md

Screenshot 2024-02-04 at 4 40 13 PM

@AviGawande
Copy link

hello @mohitvdx how do i perform the changes in my fork of this repo.

@mohitvdx
Copy link
Author

mohitvdx commented Feb 5, 2024

Hello @AviGawande, you can see the changes in the files changed.

Then you can reproduce them.

@mohitvdx
Copy link
Author

mohitvdx commented Feb 6, 2024

@walterbender kindly review

@walterbender
Copy link
Member

The change looks good. It seems that the CI test is failing (in Singer for reasons that are unrelated to your MR). I thought we had addressed the Singer issue a while back. I'll invesigate.

@mohitvdx
Copy link
Author

mohitvdx commented Feb 6, 2024

Okay sure, I'll investigate too

@mohitvdx
Copy link
Author

mohitvdx commented Feb 7, 2024

exported _state and _defaultSynth,
_polySynth is not declared inside singer>playground>pages>Voice.tsx

@walterbender
Copy link
Member

Can you put the singer changes in a separate PR?

@mohitvdx
Copy link
Author

mohitvdx commented Feb 8, 2024

Sure

@mohitvdx mohitvdx mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants