Fix view toolbar button to properly show menu when clicked

[AdityaShome]

Issue

The view menu from toolbars.py was not visible because page setup was missing.

Fixes

• Corrected the View button setup to properly link to the view_toolbar.
• View button is visible now with its previous contents "zoom in" and zoom out".
• It links the view button to open or control the view_toolbar and opens the panel when clicked.

[chimosky]

Good catch! Thank you!

Could you edit your commit message to include some of the details in your opening commit.

Would also be nice to have an extra button that'll return the zoom to the normal width if it was zoomed in or out at any point, the write activity has something similar, I can't think of another activity that does at the moment, one keeps eluding me.

[quozl]

Some of my comments in #109 also apply here.

[AdityaShome]

Along with fixing the view menu button, I included a reset button that reverts any change in font to it's normal size.
A proper tooltip was added for it.
Updated the commit message to include detailed changed.
Added keyboard shortcuts (ctrl+=, ctrl+- and ctrl+0).
I moved the dark mode and zoom buttons in view menubar as said in #109.

[chimosky]

What activity did you see using that icon for that purpose?

[AdityaShome]

I changed the icon for reset width to normal size to zoom-best-fit icon, same as the one used in write activity. Kindly review the changes.

[quozl]

Thanks, good progress. Tested.

• first line of commit message does not follow our guidance, because it is not a one line summary of change, see https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#making-commits
• button order is Zoom In followed by Zoom Out, but for Terminal it is the other way around, as is Browse, so please swap the order,
• For Zoom In, set the accelerator to Ctrl-+ to match Browse, but also respond to Ctrl-=, see Browse source,
• use "Actual size" instead of "Reset zoom", and copy the translations from the Browse activity.

It is unfortunate that Pippy has "Normal Colors" and "Inverted Colors" yet Terminal has "Switch to Light Theme" and "Switch to Dark Theme", but as these have already been translated and the purpose of the two activities differs I suppose it can be left as is.

Ctrl-0 shortcut is missing from Terminal.

I've not checked them, but other activities that use "Zoom in" include Develop, Help, ImageViewer, Labyrinth, Measure, Read, ReadETexts, SolarSystem and ViewSlides.

For your interest, the activities were initially written for a fixed display size of the OLPC XO laptop, and a deployment, school or teacher would set font name and size to meet their requirements. Children learn best without font changes, as they form connections between the letter shapes. Older children handle font changes better.

[AdityaShome]

Thanks for the detailed feedback!

• I've updated the commit message to follow the one-line summary format as per the contributing guidelines.
• Moved zoom out before zoom in button to match the format of browse activity.
• Changed tooltip "Reset zoom" to "Actual size".
• Set the accelarator to ctrl++ and also responding to ctrl+=.
• ctrl+0 is working for both editor and terminal.

[chimosky]

I don't think we need multiple approaches for this.

[AdityaShome]

Sure, I kept one approach responding to ctrl++, also ctrl+=(on most keboards).

[chimosky]

Unnecessary comment and print statement.

The activity uses logging that you should take advantage of if you need to, we don't need to in this case.

[AdityaShome]

Last commit removes the comments and print statement as it's logging is not currently required. I'll use the activity's logging system if needed in the future.