Support more and variable media types, add rawBody per claudiajs documentation#43
Open
hibes wants to merge 4 commits intosuddi:masterfrom
Open
Support more and variable media types, add rawBody per claudiajs documentation#43hibes wants to merge 4 commits intosuddi:masterfrom
rawBody per claudiajs documentation#43hibes wants to merge 4 commits intosuddi:masterfrom
Conversation
Author
|
@suddi, I don't think I have permission to add you as a reviewer to this PR. Any chance you have some time to take a look at it and provide feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to get a little closer to being in-spec with the ClaudiaJS documentations surrounding the
bodyandrawBodyfunctionality.Specifically, I noticed that if I try to either upload a file using a curl
POSTrequest or if I try to upload a string while specifying any mimetype other thanapplication/jsonorapplication/x-www-form-urlencodedthat the body is not correct. It will always have the empty object value ({}) and never have the contents which I attempted to submit viaPOST.Relevant ClaudiaJS docs:
https://github.com/claudiajs/claudia-api-builder/blob/master/docs/request-object.md