Merged
Conversation
- Update all SP1 crate pins to =6.1.0 across root, bin/client, and bin/client-op workspaces - Gate CudaProver behind `cuda` feature flag (new requirement in 6.1.0) - Add `cuda` feature to rsp-host-executor and eth-proofs - Update sp1up version in CI workflows - sp1-patches remain at sp1-6.0.0 (same major version)
|
eth-proofs is a GPU proving binary — cpu fallback doesn't make sense. Make cuda a default feature instead of gating with cfg(not(cuda)).
fa5adb3 to
6d8c12d
Compare
|
alloy-network 1.8.x adds a blanket NetworkWallet<N> impl that conflicts with op-alloy-network 0.22.x's manual impl for Optimism. Pin to <1.8 until op-alloy-network is updated.
|
SP1 6.1.0 transitively pulls reqwest 0.13.x. Without a lockfile, cargo resolves both 0.12.x (rsp direct dep) and 0.13.x (SP1 transitive dep), causing type mismatches in alloy_rpc_client.
|
This check builds without lockfiles to detect semver incompatibilities. However, rsp is consumed via git refs (not crates.io), so downstream always resolves against a specific commit. The check produces false positives from transitive dep conflicts (e.g. reqwest 0.12 vs 0.13) that are outside rsp's control.
|
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump SP1 from 6.0.2 to 6.1.0 with exact version pins.
Changes
=6.1.0(root, bin/client, bin/client-op)CudaProvergated behindcudafeature (sp1#2696 moved it behind feature flag in 6.1.0)eth-proofs: addedcudafeature (default-enabled) since it's a GPU proving binaryrsp-host-executor: addedcudafeature to forwardsp1-sdk/cudasp1up -v v6.1.0sp1-6.0.0— same major version)Test plan
cargo clippy --workspace --all-targets -- -D warningspassescargo fmt --checkpasses