Skip to content

style: avoid using star imports #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

style: avoid using star imports #438

wants to merge 2 commits into from

Conversation

nielspardon
Copy link
Contributor

This makes it easier to understand which types/constants/methods are actually used in the code.

@bestbeforetoday
Copy link
Contributor

The latest version of the Spotless plugin has a removeWildcardImports() step. Probably this change should include adoption of that Spotless capability; otherwise later changes will just end up regressing these changes and/or adding more wildcard imports.

@nielspardon
Copy link
Contributor Author

The latest version of the Spotless plugin has a removeWildcardImports() step. Probably this change should include adoption of that Spotless capability; otherwise later changes will just end up regressing these changes and/or adding more wildcard imports.

Good catch. I wasn't aware they had this now in Spotless.

@nielspardon
Copy link
Contributor Author

I rebased on latest main and pushed an additional commit upgrading spotless and enabling the removeWildcardImports option. The Spotless update did trigger some reformatting of existing code.

bestbeforetoday
bestbeforetoday approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@bestbeforetoday bestbeforetoday left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

It would be nice to figure out if we will proceed with #433 before merging this since it will introduce a fourth round of merge conflicts with that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestbeforetoday bestbeforetoday bestbeforetoday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielspardon @bestbeforetoday