Skip to content

refactor: removed unused loggers #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

refactor: removed unused loggers #435

merged 3 commits into from
Jul 23, 2025

Conversation

nielspardon
Copy link
Member

  • removes unused loggers
  • makes used loggers static
  • removes unused class AttemptTypePromotion that only consisted of a logger

bestbeforetoday
bestbeforetoday approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

vbarua
vbarua approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@vbarua vbarua changed the title Cleanup loggers refactor: removed unused loggers Jul 23, 2025
@vbarua vbarua merged commit 516c090 into substrait-io:main Jul 23, 2025
12 checks passed
@nielspardon nielspardon deleted the par-loggers branch August 5, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbarua vbarua vbarua approved these changes

@bestbeforetoday bestbeforetoday bestbeforetoday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielspardon @vbarua @bestbeforetoday