Add query engine selection field to query proto - #213
Conversation
| } | ||
|
|
||
| enum QueryEngine { | ||
| QUERY_ENGINE_UNSPECIFIED = 0; // the default (legacy) engine |
There was a problem hiding this comment.
We need
- QUERY_ENGINE_UNSPECIFIED (which semantically is QUERY_ENGINE_DEFAULT)
- QUERY_ENGINE_V1
- QUERY_ENGINE_V2
In order to force everything back if we switch all workers.
And V{1-9} i is much more forward compatible, any experimental stuff will eventually become non experimental or die
There was a problem hiding this comment.
Renaming from experimental to stable can always be done later. How about QUERY_ENGINE_DYNAMIC?
I wanted to avoid wire overhead for now, that's why I left the unspecified variant for the legacy query engine. On the worker side, we can still ignore any unknown values to remain forward-compatible.
There was a problem hiding this comment.
Another idea is just having a bool use_dynamic_query_engine for now until we have plans for a third query engine. But I thought the enum may extend for the SQL case as well
8fb2561 to
9f92e54
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
9f92e54 to
0633335
Compare
2 participants
Add a field to use the experimental query engine (https://github.com/subsquid/sqd-query-engine/)