feat: discover Chromecast devices via mDNS#21
Merged
Conversation
Chromecasts announce over mDNS (_googlecast._tcp), not SSDP, so they never appeared in scans. Browse for them in parallel with DLNA under the same timeout, dedupe re-announcements, and preserve non-default cast-group ports so grouped devices stay connectable.
Extract the entry->Info mapping out of discoverChromecast into a testable chromecastInfo helper and cover it: IPv4/IPv6 selection, DeviceName->Name->Host fallback, non-default cast-group ports, and rejection of address-less entries. Fold the name and dedupe fallbacks into cmp.Or. This branch combines the two parallel fixes for #5: the discovery implementation from #20 and the test approach from #19. Co-authored-by: Nerijus Baliūnas <591932+nerijus@users.noreply.github.com> Co-authored-by: Bartosz Fenski <fenio@debian.org>
Move discoverDLNA out of device.go into dlna.go next to connectDLNA, so each protocol's discovery and connection live in one file. Extract the entry->Info mapping into a testable dlnaInfo helper, dedupe SSDP re-announcements by USN (address fallback via cmp.Or), and add a table-driven test mirroring the chromecast one. Both discovery paths now share an identical shape.
Replace the mutex and manual WaitGroup.Add/Done in Discover with WaitGroup.Go (Go 1.25) writing two named results joined via slices.Concat, dropping the lock and the collect closure. Add compile-time var _ Device assertions next to dlnaDevice and chromecastDevice so each implementation is gated at build time.
This was referenced Jul 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromecasts announce over mDNS (
_googlecast._tcp), not SSDP, so they never showed up incastor scan. This adds Chromecast discovery next to the existing DLNA scan, so cast devices appear and can be selected.Combines #20 (@nerijus) and #19 (@fenio), both credited via Co-Authored-By. Supersedes #19 and #20.
Closes #5