Skip to content

Actually set the tlscert conn reference #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

Actually set the tlscert conn reference #259

merged 1 commit into from
Aug 12, 2025

Conversation

@singpolyma
Copy link
Contributor

@singpolyma singpolyma commented Jul 8, 2025

Previously it was always NULL

@sjaeckel sjaeckel force-pushed the actually-set-conn branch from 27f79ec to 1005f9c Compare July 15, 2025 14:25
sjaeckel
sjaeckel requested changes Jul 15, 2025
View reviewed changes
Copy link
Member

@sjaeckel sjaeckel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

  1. This dereferences tlscert before it has been NULL-checked, please fix that.
  2. Also it is missing its equivalent for GnuTLS.

@singpolyma singpolyma changed the title Actually set the tlscert conn reference when using OpenSSL Actually set the tlscert conn reference Aug 11, 2025
@singpolyma singpolyma requested a review from sjaeckel August 11, 2025 14:22
@singpolyma @sjaeckel
Actually set the tlscert conn reference
f8cda0f 
Previously it was always NULL
@sjaeckel sjaeckel merged commit f8cda0f into strophe:master Aug 12, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjaeckel sjaeckel sjaeckel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@singpolyma @sjaeckel