Callbacks when a stanza is ack'd or fails to send #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singpolyma
force-pushed
the
sm-ack-fail-callbacks
branch
from
587e2ee to
2940bef
Compare
This adds two new callbacks, one of which runs with a stanza id when a stanza sends and gets an sm ack from the server, and one which runs with a stanza id when a stanza fails and will not be retried. Incomplete and presented for discussion of the design. An id element has been added to the send/sm queue in order to facilitate passing this to the callback without re-parsing the stanza. This is also added to the sm serialization, though we could parse the stanza on restore to avoid this I suppose. TODO: fail everything on stream end
singpolyma
force-pushed
the
sm-ack-fail-callbacks
branch
from
a936b56 to
f60571d
Compare
Contributor
Author
|
Hmm, we probably also want stanza type at least as well (iq, message, presence) since for my implementation at least I can ignore iq acks usually and just want message ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new callbacks, one of which runs with a stanza id when a stanza sends and gets an sm ack from the server, and one which runs with a stanza id when a stanza fails and will not be retried.
Incomplete and presented for discussion of the design.
An id element has been added to the send/sm queue in order to facilitate passing this to the callback without re-parsing the stanza.
This is also added to the sm serialization, though we could parse the stanza on restore to avoid this I suppose.