feat: add support for multiple fixture files in fixtures command #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixtures command previously only accepted a single file argument. This change allows users to pass multiple fixture files which will be processed sequentially, eliminating the need to chain multiple commands with && operators. Changes: - Updated fixtures command to accept at least one argument (MinimumNArgs) instead of exactly one argument (ExactArgs) - Added loop to process each fixture file sequentially - Implemented MinimumNArgs validator function in validators package to support the new argument validation Usage: stripe fixtures file1.json file2.json file3.json Fixes stripe#910
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixturescommandRationale
Previously, users needed to chain multiple
stripe fixturescommands using&&:stripe fixtures ./subscription.created.json && stripe fixtures ./teardown.jsonThis change allows a simpler syntax:
This improves developer experience by reducing repetition and making it easier to run multiple fixtures together.
Changes Made
pkg/cmd/fixtures.go:
ExactArgs(1)toMinimumNArgs(1)to accept one or more filespkg/validators/cmds.go:
MinimumNArgs()validator functionMaximumNArgs()andExactArgs()validatorsTest Plan
./stripe fixtures --helpdisplays correctly./stripe fixturesshows appropriate error messageThe implementation maintains backward compatibility - single file usage continues to work as before.
Fixes #910