Rewrite the Clan System#389
Open
stridera wants to merge 14 commits into
Open
Conversation
Update build test to use cmake/Ninja/and check the executable after
…ication - Added save_player_char(ch) calls to clan_store and clan_retrieve functions - Added clan_repository.save() calls to clan_store and clan_retrieve functions - Ensures character and clan data is persisted immediately after successful operations - Prevents potential item duplication from server crashes or disconnections - Bank functions (clan_deposit/clan_withdraw) already had proper save operations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added .cache/ to ignore clangd index files - Added .serena/ to ignore local AI assistant cache files - Removed these directories from repository tracking 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
stridera
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds substantial documentation and modernization guidance to the project, focusing on code quality, scripting capabilities, and workflow improvements. The most important changes are grouped below:
Documentation and Guidelines
.github/copilot-instructions.md, detailing required C++23 features, forbidden legacy practices, and code cleanup requirements for contributors.Analysis.mdcovering architecture, code quality, security, performance, design patterns, and prioritized recommendations for the codebase.CLAN_SCRIPTING.md, a thorough guide for using clan-related variables and scripting examples in DG Scripts, enabling advanced in-game scripting for clans.Build and Workflow Improvements