-
-
Notifications
You must be signed in to change notification settings - Fork 147
fix(input): use None as default for Maybe fields instead of UNSET #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideAdjusts default values for Maybe fields in Strawberry Django input types to use None (matching core Strawberry behavior) while keeping UNSET as the default for other optional fields, and adds tests to lock in the new behavior. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
=======================================
Coverage 89.71% 89.72%
=======================================
Files 45 45
Lines 4318 4321 +3
=======================================
+ Hits 3874 3877 +3
Misses 444 444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DrumsnChocolate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Fix #753
Summary by Sourcery
Adjust input type handling so Maybe fields default to None instead of UNSET, aligning Django input behavior with core Strawberry, and add tests to verify the new defaults.
Bug Fixes:
Tests: