Skip to content

Conversation

@bellini666
Copy link
Member

@bellini666 bellini666 commented Dec 8, 2025

Fix #753

Summary by Sourcery

Adjust input type handling so Maybe fields default to None instead of UNSET, aligning Django input behavior with core Strawberry, and add tests to verify the new defaults.

Bug Fixes:

  • Ensure Maybe fields in Django input types use None as the default value to match Strawberry's behavior instead of UNSET.

Tests:

  • Add tests verifying default values for Maybe and regular optional fields in Django and Strawberry input types.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 8, 2025

Reviewer's Guide

Adjusts default values for Maybe fields in Strawberry Django input types to use None (matching core Strawberry behavior) while keeping UNSET as the default for other optional fields, and adds tests to lock in the new behavior.

File-Level Changes

Change Details Files
Change input type processing so Maybe[...] fields default to None instead of UNSET while keeping UNSET for other fields.
  • Detect Maybe-annotated fields during input type processing using _annotation_is_maybe
  • Compute a per-field default_value of None for Maybe fields and UNSET for all other fields
  • When the field is defined on the class with a MISSING default, set both dataclasses.Field.default and StrawberryField.default_value to the computed default_value
  • When synthesizing a new field for inputs, propagate the computed default_value to both dataclasses default and StrawberryField.default_value
strawberry_django/type.py
Add regression test asserting default values for Maybe and regular optional fields on Strawberry Django input types match core Strawberry behavior.
  • Define new InputWithMaybe and StrawberryInputWithMaybe input types with Maybe[bool] and regular optional fields
  • Collect dataclass fields for both Django and Strawberry inputs for comparison
  • Assert that Maybe field defaults are None and consistent between Django and Strawberry inputs
  • Assert that a regular optional field on the Django input still defaults to strawberry.UNSET
tests/types2/test_input.py

Possibly linked issues

  • #Support the new strawberry.Maybe type: PR adds tests and changes input processing so Maybe fields default to None, directly contributing to Maybe support.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (49776a2) to head (f9b81b7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   89.71%   89.72%           
=======================================
  Files          45       45           
  Lines        4318     4321    +3     
=======================================
+ Hits         3874     3877    +3     
  Misses        444      444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@DrumsnChocolate DrumsnChocolate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@bellini666 bellini666 merged commit 45d48c4 into main Dec 8, 2025
48 checks passed
@bellini666 bellini666 deleted the fix-maybe branch December 8, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the new strawberry.Maybe type

3 participants