Cleanup StrataMain python commands #277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqjune-aws
reviewed
Dec 17, 2025
| (cd ../../../Tools/Python && python -m strata.gen py_to_strata "../../StrataTest/Languages/Python/$test_file" "../../StrataTest/Languages/Python/$ion_file") | ||
|
|
||
| output=$(cd ../../.. && lake exe strata pyAnalyze --include Tools/Python/test_results/dialects "StrataTest/Languages/Python/${ion_file}" 0) | ||
| output=$(cd ../../.. && lake exe strata pyAnalyze --include Tools/Python/test_results/dialects "StrataTest/Languages/Python/${ion_file}") |
Contributor
There was a problem hiding this comment.
I think --include isn't necessary because the Python dialect must have been already included in Strata during compilation. Do you want to check whether removing this works?
joehendrix
requested changes
Dec 18, 2025
| let (sp, args) ← process {} #[] remainingArgs | ||
| if p : args.size = cmd.args.length then | ||
| cmd.callback sp ⟨args, p⟩ | ||
| match cmd.flagsCallback with |
Contributor
There was a problem hiding this comment.
flagsCallback seems overly specific to me. How about we having a generic callback that takes the remaining args as a list of strings? and the functionality between lines 214 and 240 are moved into a standalone function that each callback can invoke?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup StrataMain python commands
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.