-
Notifications
You must be signed in to change notification settings - Fork 54
feat: Add MCP client tool #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkmeral
wants to merge
8
commits into
strands-agents:main
Choose a base branch
from
mkmeral:mcp-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f33c742
feat: Add MCP client tool
be4e945
fix: mcp_client failing on empty tool args
04d9fe0
Merge branch 'main' into mcp-client
ebf57c7
feat: add streamable HTTP transport support to MCP client
3e1abdd
fix: readme MCP client signature update
20e55d0
Improve content type handling and add environment variable for mcp ti…
90ca572
Merge branch 'main' into mcp-client
dfa6854
fix: run formatter
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we edit this to callout that we are allowing an agent to autonomously perform this connection and dynamic loading. This was brought up on a client call and, as expected, this was called out as being potentially dangerous.
This tool is useful, I want to prevent customers from accidentally doing something like the following instead of using the MCPClient approach in the SDK
This be be documentation, but I also have concerns with this tool being called mcp_client. I would bet that we will get customers asking us "should I use mcp_client tool or MCPClient" because of this.