-
Notifications
You must be signed in to change notification settings - Fork 322
fix(event_loop): ensure tool_use content blocks are valid after max_tokens to prevent unrecoverable state #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dbschmigelski
merged 26 commits into
strands-agents:main
from
dbschmigelski:hook-provider
Aug 8, 2025
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c5e4e51
fix(event_loop): raise dedicated exception when encountering max toke…
dbschmigelski 6703819
fix: update integ tests
dbschmigelski c94b74e
fix: rename exception message, add to exception, move earlier in cycle
dbschmigelski 36dd0f9
Update tests_integ/test_max_tokens_reached.py
dbschmigelski e04c73d
Update tests_integ/test_max_tokens_reached.py
dbschmigelski cca2f86
linting
dbschmigelski f647baa
Merge branch 'strands-agents:main' into fix-max-tokens
dbschmigelski 78c5a91
Merge branch 'strands-agents:main' into fix-max-tokens
dbschmigelski a208496
Merge branch 'strands-agents:main' into fix-max-tokens
dbschmigelski 2e2d4df
feat: add builtin hook provider to address max tokens reached truncation
dbschmigelski 447d147
tests: modify integ test to inspect message history
dbschmigelski 564895d
fix: fix linting errors
dbschmigelski 2f118fb
fix: linting
dbschmigelski e5fc51a
refactor: switch from hook approach to conversation manager
dbschmigelski 5906fc2
linting
dbschmigelski 87445a3
fix: test contained incorrect assertions
dbschmigelski 924fea9
fix: add event emission
dbschmigelski 104f6b4
feat: move to async
dbschmigelski 11b91f4
feat: add additional error case where no tool uses were fixed
dbschmigelski 1da9ba7
feat: add max tokens reached test
dbschmigelski 623f3c7
linting
dbschmigelski 66c4c07
feat: add max tokens reached test
dbschmigelski 4b5c5a7
feat: switch to a default behavior to recover from max tokens reached
dbschmigelski 83ad822
fix: all tool uses now must be replaced
dbschmigelski faa4618
fix: boolean
dbschmigelski fa8195f
remove todo
dbschmigelski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
src/strands/event_loop/_recover_message_on_max_tokens_reached.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
"""Message recovery utilities for handling max token limit scenarios. | ||
|
||
This module provides functionality to recover and clean up incomplete messages that occur | ||
when model responses are truncated due to maximum token limits being reached. It specifically | ||
handles cases where tool use blocks are incomplete or malformed due to truncation. | ||
""" | ||
|
||
import logging | ||
|
||
from ..types.content import ContentBlock, Message | ||
from ..types.tools import ToolUse | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
def recover_message_on_max_tokens_reached(message: Message) -> Message: | ||
"""Recover and clean up messages when max token limits are reached. | ||
|
||
When a model response is truncated due to maximum token limits, all tool use blocks | ||
should be replaced with informative error messages since they may be incomplete or | ||
unreliable. This function inspects the message content and: | ||
|
||
1. Identifies all tool use blocks (regardless of validity) | ||
2. Replaces all tool uses with informative error messages | ||
3. Preserves all non-tool content blocks (text, images, etc.) | ||
4. Returns a cleaned message suitable for conversation history | ||
|
||
This recovery mechanism ensures that the conversation can continue gracefully even when | ||
model responses are truncated, providing clear feedback about what happened and preventing | ||
potentially incomplete or corrupted tool executions. | ||
|
||
Args: | ||
message: The potentially incomplete message from the model that was truncated | ||
due to max token limits. | ||
|
||
Returns: | ||
A cleaned Message with all tool uses replaced by explanatory text content. | ||
The returned message maintains the same role as the input message. | ||
|
||
Example: | ||
If a message contains any tool use (complete or incomplete): | ||
``` | ||
{"toolUse": {"name": "calculator", "input": {"expression": "2+2"}, "toolUseId": "123"}} | ||
``` | ||
|
||
It will be replaced with: | ||
``` | ||
{"text": "The selected tool calculator's tool use was incomplete due to maximum token limits being reached."} | ||
``` | ||
""" | ||
logger.info("handling max_tokens stop reason - replacing all tool uses with error messages") | ||
|
||
valid_content: list[ContentBlock] = [] | ||
for content in message["content"] or []: | ||
tool_use: ToolUse | None = content.get("toolUse") | ||
if not tool_use: | ||
valid_content.append(content) | ||
continue | ||
|
||
# Replace all tool uses with error messages when max_tokens is reached | ||
display_name = tool_use.get("name") or "<unknown>" | ||
logger.warning("tool_name=<%s> | replacing with error message due to max_tokens truncation.", display_name) | ||
|
||
valid_content.append( | ||
{ | ||
"text": f"The selected tool {display_name}'s tool use was incomplete due " | ||
f"to maximum token limits being reached." | ||
} | ||
) | ||
|
||
return {"content": valid_content, "role": message["role"]} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.