Skip to content

Change max_tokens type to int to match Anthropic API #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

vinc3m1
Copy link
Contributor

@vinc3m1 vinc3m1 commented Jul 31, 2025

Using a string as suggested by the type annotation causes the Anthropic API call to fail:

anthropic.BadRequestError: Error code: 400 - {'type': 'error', 'error': {'type': 'invalid_request_error', 'message': 'max_tokens: Input should be a valid integer'}}

Description

Just a quick type change.

Documentation PR

Documentation actually looks right, just the type annotation is incorrect.

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Unshure
Copy link
Member

Unshure commented Aug 1, 2025

Linting is failing, but two recent commits have fixed this. Can you sync your fork so I can re-run the checks?

Using a string causes the Anthropic API call to fail:
```
anthropic.BadRequestError: Error code: 400 - {'type': 'error', 'error': {'type': 'invalid_request_error', 'message': 'max_tokens: Input should be a valid integer'}}
```
@vinc3m1
Copy link
Contributor Author

vinc3m1 commented Aug 1, 2025

Rebased! Thanks

@Unshure Unshure merged commit 09ca806 into strands-agents:main Aug 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants