Handle html encoded values in comment bindings #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing unencoded values in comments allows values such as
--><script>alert(1)</script><!--
to be passed through and these will be executed by the browser. To prevent this, the values need to be html encoded, eg into"--><script>alert(1)</script><!--
. Existing Quench won't decode these values.This change uses the DOMParser to decode strings that include these escaped characters, so a comment binding like this works: