Skip to content

feat: shift click to quick mention a user - #1271

Open
Asraye wants to merge 3 commits into
stoatchat:mainfrom
Asraye:feat/shift-click-mention
Open

feat: shift click to quick mention a user#1271
Asraye wants to merge 3 commits into
stoatchat:mainfrom
Asraye:feat/shift-click-mention

Conversation

@Asraye

@Asraye Asraye commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Adds an easy way to mention a user by pressing shift + click, on a username. Whether they're in the sidebar, a reply origin or just a general message!

Saw this in the "NOTES" and thought I'd take a crack, I tried a few different ways and found this to be the best approach with the least required changes and the least jank.

  • Undepreciated: "Username", as we now use it to pass the UserId and handle the logic

How was this PR tested?

Tested locally with all edited areas (E.G: Replies, sidebar and messages - As seen in video)

Screenshots & Screencasts (if appropriate)

ShiftyClicky.mp4

Checklist:

  • I have carefully read the contributing guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR
  • I have confirmed that any new dependencies are strictly necessary
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code

Please declare, if any, LLM usage involved in creating this PR

None; Just staying up past my sleepy time (I was meant to sleep 3 hours ago, I've spent 3 hours on this..)
...

Remember to Squash this into one commit... It took me two tries to fix lint.

Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
@Asraye
Asraye requested review from a team as code owners June 10, 2026 17:26
Asraye added 2 commits June 11, 2026 13:18
Fix up build & lint from tired me 😴

Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
PoBruno added a commit to PoBruno/stoat-for-web that referenced this pull request Aug 24, 2026
Mentioning someone meant typing an at sign and enough of their name for
the autocomplete to find them, even when the person was right there in the
message you were reading. Holding shift and clicking their name now
appends the mention to whatever is already in the box.

From stoatchat#1271. It was written against a version of the
message component that predates the context wrapper this fork uses, so the
whole block collided; the only part that belongs there is the user id
being handed to the username, which is what the click needs to know who to
mention.

The callback it registers on the draft store had no cleanup, unlike the
one registered beside it, so it went on pointing at a composition that had
already been unmounted after switching channels.

Signed-off-by: pobruno <brunoshy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants