refactor: add mise, update electron-forge, add ci/cd workflow for lint - #252
Merged
Conversation
Dadadah
requested review from
Arsabutispik,
IAmTomahawkx,
chrishultin and
insertish
July 24, 2026 06:26
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Dadadah
force-pushed
the
refactor/addmise
branch
from
July 24, 2026 06:28
175de0c to
bc818fa
Compare
Arsabutispik
approved these changes
Jul 24, 2026
devoliverluccas
added a commit
to devoliverluccas/for-desktop
that referenced
this pull request
Aug 19, 2026
…red up Both `native/autoLaunch.ts` and `native/badges.ts` registered their IPC handlers as an import side effect, and nothing imported either module, so the handlers did not exist at runtime. For autostart this was a regression: - e00f3a8 (stoatchat#237) removed the last direct use of `autoLaunch`, leaving the import unused - 6894231 (stoatchat#252) then removed the now-unused import during the lint pass `ipcMain.handle("getAutostart"/"setAutostart")` went with it, so the renderer's `desktopConfig.setAutostart()` rejects with "No handler registered" and the toggle in settings silently does nothing. Closes stoatchat#287. Badges were never wired up at all -- `git log -S 'native/badges'` shows the module has not been imported since the initial commit, even though the preload bridge has exposed `native.setBadgeCount()` since stoatchat#25. Refs stoatchat#213. Both modules now expose an explicit `init*()` that `main.ts` calls, so the registration is tied to a call the linter cannot quietly drop. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Lucas Oliveira <lucasferreiradeoliveira.20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mise!
Update electron forge
Add linting and formatting to build ci/cd workflow
Fix some linting and formatting errors
Fix some types missing
Fix some dev imports missing
Fix appx import being shipped with the app (wtf?)
Some of the fixes in this PR were present in #187, so thanks @Lynden-Sylvester
main