Skip to content

Potential fix for 1 code quality finding in file remote.c #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nightwalker-87 merged 1 commit into from
Jul 6, 2026
+3 −2
Merged

Potential fix for 1 code quality finding in file remote.c #1499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/stlink-lib/remote.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,11 +334,12 @@ static int32_t rb_read_unsupported_reg(stlink_t *sl, int32_t r_idx, struct stlin

static int32_t rb_write_unsupported_reg(stlink_t *sl, uint32_t value, int32_t r_idx, struct stlink_reg *regp) {
uint8_t p[REG_WIRE_LEN];
uint8_t rp[REG_WIRE_LEN];
uint32_t pl;
reg_to_wire(p, regp);
int32_t ret = remote_rpc(sl, RPC_WRITE_UNSUPPORTED_REG, value, (uint32_t)r_idx,
p, sizeof(p), p, sizeof(p), &pl);
if (ret == 0 && pl == REG_WIRE_LEN) { reg_from_wire(regp, p); }
p, sizeof(p), rp, sizeof(rp), &pl);
if (ret == 0 && pl == REG_WIRE_LEN) { reg_from_wire(regp, rp); }
else if (ret == 0) { ret = -1; }
return (ret);
}
Expand Down
Loading