Repository navigation
build(deps): allow php-di ^7.0 - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the
php-di/php-diconstraint from^6.3to^6.3 || ^7.0.Laravel 13 apps couldn't install php-di 6.4 next to
laravel/serializable-closurev2, so Composer fell back to php-di 6.3.5. That version pulls in the abandonedopis/closure, which prints deprecation warnings on PHP 8.4. php-di 7 works with serializable-closure v1 and v2.I resolved the lock with PHP 8.3.22. These packages changed:
Testing
composer validateandcomposer check-platform-reqs --lockpass on PHP 8.3; the only missing requirement isext-xdebug, which is dev-only.phpunit: 107 tests, 10 errors, the same result as onmain. All 10 errors are an existing nette/php-generator problem (ITestActor cannot be represented with ClassType) inDynamicGenerator/FileGenerator. php-di isn't involved, so I'll fix that separately.🤖 Generated with Claude Code