Updated UTC time conversion#36
Open
jlevers wants to merge 3 commits intostilldavid:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated
gpsu.goto include the milliseconds in the format string―it doesn't change functionality, but I thought it made it a little more clear as to what the input data actually looked like (I believe the format isyymmddhhmmss.sssas per gpmf-parser's README).The change in
telemetry.gomakes it so that the UTC timestamps produced bygopro2jsondon't have an extra 30's at the end of them, as mentioned in my comment in #33. Also, the 3 digits before the trailing zeros (corresponding to milliseconds) are now after the decimal. With this change, the JSON UTC timestamps are valid Unix timestamps. The 3 digits after the decimal place are milliseconds.Please let me know if there are any changes you'd like me to make...thanks!