-
Notifications
You must be signed in to change notification settings - Fork 30
(Closes #473) ensures that a file containing only comments does not give a syntax error. #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
=======================================
Coverage 92.15% 92.16%
=======================================
Files 86 86
Lines 13733 13752 +19
=======================================
+ Hits 12656 12674 +18
- Misses 1077 1078 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@schreiberx would you mind giving this branch of fparser ( |
I tested it on one file & it works. Thanks! |
Ready for review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix. Took me a while to understand this, and I feel we should either add or modify the test that tests the actual bug. Could you also bring this up to maste?
Ready for another look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to be merged. All comments from review addressed, documentation builds the same it did before
No description provided.