Skip to content

(Closes #473) ensures that a file containing only comments does not give a syntax error. #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 31, 2025

Conversation

arporter
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.16%. Comparing base (c0e4626) to head (02be015).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   92.15%   92.16%           
=======================================
  Files          86       86           
  Lines       13733    13752   +19     
=======================================
+ Hits        12656    12674   +18     
- Misses       1077     1078    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter
Copy link
Member Author

@schreiberx would you mind giving this branch of fparser (473_comments_only) a go and checking that it fixes the issue when there are only comments (and doesn't introduce any new ones)? Thanks :-)

@schreiberx
Copy link

I tested it on one file & it works. Thanks!

@arporter
Copy link
Member Author

Ready for review :-)

Copy link
Collaborator

@hiker hiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. Took me a while to understand this, and I feel we should either add or modify the test that tests the actual bug. Could you also bring this up to maste?

@hiker hiker added reviewed with actions PR has been reviewed and is back with developer and removed under review labels Jul 24, 2025
@arporter
Copy link
Member Author

Ready for another look now.

@arporter arporter added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Jul 29, 2025
Copy link
Collaborator

@hiker hiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged. All comments from review addressed, documentation builds the same it did before

@hiker hiker merged commit afb9da7 into master Jul 31, 2025
5 checks passed
@hiker hiker deleted the 473_comments_only branch July 31, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants