Add SaveMap service and improve depth settings for mapping - #457
Open
felipesanmartin wants to merge 3 commits into
Open
Add SaveMap service and improve depth settings for mapping#457felipesanmartin wants to merge 3 commits into
felipesanmartin wants to merge 3 commits into
Conversation
…pthSetting call, that is needed to run mapping without subscribe to depth topic (headless). Move fusedCloudSubCount after ZED SDK processing to update Spatial Mapping without publish fused cloud. Get last SpatialMap before save it
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds support for saving the Spatial Mapping point cloud to a file through a dedicated ROS2 service. This enables users to persist the generated 3D map without needing to manually capture or reprocess the data from runtime streams. The change is implemented as a non-breaking feature and is intended to improve usability for offline processing, debugging, and map export workflows.
I had to modified zed-ros2-interfaces too to add the new service definition. I added my fork as submodule, but it should be removed if my changes are accepted in that repository and release as new version of zed_msgs.
🔗 Related Issues / Tickets
A related issue is 295, an user ask for this functionality.
🚀 Type of Change
🧪 How Has This Been Tested?
Manual Verification: Steps taken to verify visually or functionally.
ros2 service call /zed/zed_node/save_map zed_msgs/srv/SaveMap "{map_filename: "test_srv", file_format: 0}")⬜ Pre-Merge Checklist