Conversation
…OICE_ubl.xml) Check for ElectronicAddress.Address != '' like in CII (fails 01.01a-INVOICE_ubl.xml too)
|
Thanks for the fix. imho you can make the change more specific by explicitly stating the XPath: https://docs.peppol.eu/poacc/billing/3.0/syntax/ubl-invoice/cac-InvoicePeriod/ |
|
Sorry, but the more specific XPath /ubl:Invoice.. does not work |
strange. Could you add a test case to the unit test class? |
|
I added a test and also corrected the test TestReferenceXRechnung21UBL: Name has to be equal "". |
- UBL Reader: TaxRepresentativeParty XPath ohne /cac:Party (BUG 1) In UBL 2.1 ist TaxRepresentativeParty direkt vom Typ PartyType - UBL Writer: BillingPeriod prueft jetzt Start OR End statt End OR End (BUG 2) - UBL Reader: UnitCode Fallback auch fuer CreditedQuantity (BUG 4)
- v1.0 Reader: BillingPeriod XPath ApplicableHeaderTradeSettlement -> ApplicableSupplyChainTradeSettlement - v1.0 Reader: _nodeAsParty Street = lineTwo statt lineOne wenn lineTwo existiert - v1.0 Reader: penaltyActualAmount XPath DiscountTerms -> PenaltyTerms - v2.0 Reader: penaltyActualAmount XPath DiscountTerms -> PenaltyTerms - v2.3 Reader: penaltyActualAmount XPath DiscountTerms -> PenaltyTerms - InvoiceValidator: taxBasis Diagnostik-Meldung fehlte + chargeTotal
|
| if (!String.IsNullOrWhiteSpace(lineTwo)) | ||
| { | ||
| retval.ContactName = lineOne; | ||
| retval.Street = lineOne; |
There was a problem hiding this comment.
This behaviour is consistent across all versions. I'd leave this like it is, i.e.
retval.Street = LineOne
retval.Street2 = LineTwo
There was a problem hiding this comment.
I've implementied it as per PR #863 where you said:
"'d like to leave the mapping as it was for consistency purpose.
Street = lineTwo
Street2 = lineOne"
2 participants
Summary
UBL fixes
Checklist
.Result/GetAwaiter().GetResult())CancellationTokenrespecteddotnet buildno warnings as errors)dotnet format --verify-no-changespassesBreaking changes?