CRAN check resolve #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks Chen it looks good.
…--
Stefano Mangiola
From: Chen Zhan ***@***.***>
Date: Tuesday, 9 September 2025 at 10:05 PM
To: stemangiola/tidyseurat ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [stemangiola/tidyseurat] CRAN check resolve (PR #88)
1. Rd cross-references for formatting.Rd: tbl_format_setup
2. package dependencies for ‘SingleR’: remove it from DESCRIPTION as it is a non-CRAN package. We still mention/use them in vignettes conditionally by setting eval=FALSE
Tested locally, the above notes are resolved.
________________________________
You can view, comment on, or merge this pull request online at:
#88
Commit Summary
* be272f8<be272f8> CRAN check resolve
File Changes
(3 files<https://github.com/stemangiola/tidyseurat/pull/88/files>)
* M DESCRIPTION<https://github.com/stemangiola/tidyseurat/pull/88/files#diff-9cc358405149db607ff830a16f0b4b21f7366e3c99ec00d52800acebe21b231c> (3)
* M R/print_method.R<https://github.com/stemangiola/tidyseurat/pull/88/files#diff-82e7769df322cb82c035518cc62ebdb9f198fb8e90d3317b6076e1f95679cbc3> (1)
* M man/formatting.Rd<https://github.com/stemangiola/tidyseurat/pull/88/files#diff-dc38869073269f6b4ff0ab457e32ee2d4fac6ab966fd839596ba08f870ac7747> (2)
Patch Links:
* https://github.com/stemangiola/tidyseurat/pull/88.patch
* https://github.com/stemangiola/tidyseurat/pull/88.diff
—
Reply to this email directly, view it on GitHub<#88>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABXF26UNFSKENPKRGJFWXXT3R3CQFAVCNFSM6AAAAACGAVQAJOVHI2DSMVQWIX3LMV43ASLTON2WKOZTGM4TQMRVGYZTENQ>.
You are receiving this because you are subscribed to this thread.
|
stemangiola
requested changes
Sep 15, 2025
Owner
stemangiola
left a comment
stemangiola
left a comment
There was a problem hiding this comment.
When you do a PR you should always bump the package version, in this case the minor version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval=FALSETested locally, the above notes are resolved.