Improve health check for wallet backend services #251
Conversation
…integration tests
aditya1702
changed the title
| rpcHealth, err := h.RPCService.GetHealth() | ||
| if err != nil { | ||
| httperror.InternalServerError(ctx, "", err, nil, h.AppTracker).Render(w) | ||
| return | ||
| } |
There was a problem hiding this comment.
Reaching RPC every time might not be the best approach here.
Can we use something like a 1-minute cache here?
There was a problem hiding this comment.
Hmm, I dont think it should be an issue here since its a health check and it doesnt impact any other wallet-backend operation. Are you thinking it would slow down requests from RPC side? I assume it can handle multiple health requests and also other endpoint requests? cc @Shaptic @2opremio any thoughts here?
There was a problem hiding this comment.
It’s definitely fine to have this be in parallel with other requests. In fact I’m fairly certain this is exactly what happens in our k8s deployment. I’d recommend wrapping the message in the returned error, though, for verbosity.
What
Why
We spin up the API and Ingest services separately in our kubernetes environment. The ingest service needs a health check endpoint so that the readiness probe for kube can be configured to check for ingest service health.
Known limitations
N/A
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release