Remove loadgen account creation mode, simplify upgrade path in tests #4827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
force-pushed
the
accountCreationDeprecation
branch
3 times, most recently
from
5da7a45 to
a84cc33
Compare
marta-lokhova
force-pushed
the
accountCreationDeprecation
branch
from
a84cc33 to
dba45e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4677
Resolves #4445
While testing the pipelining prototype, I ran into a few annoyances in tests, specifically related to account creation path. We've been wanting to fix those anyway, so I went ahead and cleaned that up to ease further testing. We should merge this PR when master is open.
Most of the code was put together by @claude