V17 feature branch by Ryang-21 · Pull Request #1580 · stellar/js-stellar-sdk

Ryang-21 · 2026-07-31T20:27:46Z

No description provided.

* feat(xdr): codegen tool + schema source * feat(xdr): add class-based XDR runtime and sep51 JSON walker * refactor(numbers): drop LargeInt classes, delegate to new XDR layer * refactor(base): migrate src/base to new XDR layer; drop legacy xdr.ts + generated * refactor: migrate downstream consumers (bindings/contract/horizon/rpc/webauth) * feat(base/scval): add bool to ScValType * allow opaque xdr types to be initalized via string * refactor xdr strings to be represented soley via bytes with a dx friendly XdrString wrapper class * generate a value getter function for void union cases * add a is() function to the generated XDR union classes for instanceOf checks * build: adopt @stellar/js-xdr v5 as an external dependency * feat(xdr): regenerate schemas against @stellar/js-xdr and add CAP-71 credentials * feat(xdr): wire the toJSON hook so JSON.stringify emits SEP-0051 * fix(bindings): emit Uint8Array for bytes/bytesN to match scValToNative * refactor(contract): rename fromJSON to fromJson with deprecated aliases * feat(xdr): accept ASCII asset codes with zero padding in constructors

* feat(base): migrate crypto and strkey APIs to Uint8Array * feat(base)!: migrate value types to Uint8Array * feat(base)!: migrate transactions, operations, and auth to Uint8Array * feat!: migrate contract, rpc, and webauth layers to Uint8Array * test: migrate tests off Buffer to Uint8Array * build!: drop buffer polyfill and dependency * docs: add Uint8Array migration guide and changelog entry * test: add coverage for Keypair to ensure seed copying instead of aliasing memory * docs: update changelog to clarify Uint8Array migration details * regen docs * test: update bindings snapshot for Uint8Array deploy signature * fix(horizon): type manage_data value as string to match runtime API * docs: add changelog entry for manage_data value type fix * docs: drop stale Buffer polyfill guidance for RN, Expo, and Workers

…mmit (#1575)

… ungated (#1576) * build(xdr): regenerate schema from stellar-xdr with CAP-83 and CAP-85 ungated * fix(xdr): keep consumers compiling against the regenerated union arms * ci(browser-tests): run each transport in its own job * fix(vitest): isolate browser dep cache per transport

…cutables (#1577) * build(xdr): fail the schema download instead of masking it in a pipe * feat(xdr): support CAP-83 and CAP-85 protocol values

…ode (#1581) * fix(xdr): bound decimal string length before BigInt parse in json decode * refactor(xdr): name the digit-budget constants in bigint-parts

#1582) * fix(xdr): restrict fromJson to SEP-51 keys and reject unknown fields * fix(test): correct horizon corpus fixture path so corpus tests run * test(xdr): add JSON round-trips for mainnet corpus values

…ptional (#1586)

* fix(strkey): validate signed payload framing in decodeCheck * docs: regenerate core-keys source line references * test(strkey): cover SEP-23 signed payload invalid vectors * docs(changelog): note signed payload strkey framing validation

…1589) * test(xdr): source the real-traffic corpus from both Horizon and RPC * Update comment Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ength (#1591)

* fix(xdr): throw on unknown union discriminant in fromXdrObject * test(xdr): cover the union dispatch guard across every union * fix(strkey): validate the claimable balance discriminant byte * fix(xdr): reject non-decimal integer strings in JSON decoding * test(xdr): assert JSON and XDR decoding reject the same values

* docs(changelog): rewrite the xdr breaking-change entry * docs(xdr): correct migration guide errors and link both guides * docs(xdr): document renames, optionals, removed exports, and errors * docs: link migration guides from readme, the source of docs/index.md * docs: index v17 migrations in the central migration guide * docs: update migration section wording for clarity * docs(xdr): apply review feedback on counts, aliases, and optionals * Update docs/index.md Co-authored-by: Iveta <quietbits@users.noreply.github.com> * V17.0.0 rc.1 (#1593) * docs(changelog): record sdk-level behavior changes from the xdr rebuild * chore(release): cut v17.0.0-rc.1 * test(e2e): restore test-contracts pointer lost in the #1579 merge * simplify rc tag for npm publish --------- Co-authored-by: Iveta <quietbits@users.noreply.github.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

…ation

…ecipe

* feat(xdr): add validateXdr static to every generated type * docs(xdr): file validateXdr under renames, not removals

Shaptic · 2026-08-06T23:37:33Z

+  * Enums are singletons, not factory calls: `xdr.ContractDataDurability.persistent()` becomes `xdr.ContractDataDurability.persistent`.
+  * Primitives are plain JS values. Integers are `number` or `bigint` instead of class wrappers, `LargeInt` subclasses are gone, byte fields are `Uint8Array`, and fields are `readonly`.
+  * Absent optional fields decode to `null` instead of `undefined`, so `=== undefined` checks silently stop matching. Prefer `== null`.
+  * Acronyms in method names collapse to single-initial-cap form, with no back-compat aliases. This reaches beyond the `xdr` namespace to the wrapper classes: `Transaction#toXDR()`, `TransactionBuilder.fromXDR()`, `Operation.fromXDRObject()`, `Asset#toXDRObject()`, `contract.AssembledTransaction#toXDR()` and others all gained the `Xdr` spelling.


why are some of these #s and some aren't?

Shaptic · 2026-08-06T23:38:36Z

+  * Removed: `Reader` and `Writer`; the v4 runtime type constructors (`Hyper`, `UnsignedHyper`, `Option`, `Opaque`, `VarOpaque`, `XDRArray`, `XDRString`, `Bool`, `SignedInt`, `UnsignedInt`), plus top-level `Hyper` / `UnsignedHyper` / `cereal`; the `validateXDR()` static on every type (use `try`/`catch` around `fromXdr`); and `xdr.scvSortedMap` (use the top-level `scvSortedMap`).
+  * `ScInt` and `XdrLargeInt` lost their `.int` property; read `.value` (a `bigint`) instead, and note `valueOf()` now returns a `bigint`.
+
+  [`docs/XDR_MIGRATION.md`](./docs/XDR_MIGRATION.md) covers every change with before/after examples and a quick-reference table.


This should be earlier, either before the top-level bullet or first bullet and also bolded.

Shaptic · 2026-08-06T23:39:06Z

+  [`docs/XDR_MIGRATION.md`](./docs/XDR_MIGRATION.md) covers every change with before/after examples and a quick-reference table.
+
+* Rebuilding the XDR layer changed a few SDK-level behaviors that don't involve typing `xdr.` yourself. Most of these fail silently, so they won't surface as compile errors ([#1422](https://github.com/stellar/js-stellar-sdk/pull/1422)):
+  * `scValToNative` returns a `Uint8Array` for an `scvString` / `scvSymbol` whose contents aren't valid UTF-8. It previously always returned a string, substituting U+FFFD — its byte-returning branch was unreachable. Guards like `typeof result === "string"` and calls like `result.startsWith(...)` are now data-dependent. The same applies to `contract.Spec#scValToNative` and `#funcResToNative` for `Bytes` / `BytesN`, which return `Uint8Array`; those are generically typed, so TypeScript won't flag it.


whose contents aren't valid UTF-8

Symbol will always be UTF8

Its not guaranteed since you can also provide bytes outside of the utf8 range

Symbols are guaranteed by Core itself to always be in the range [A-Za-z_] or something like that.

Aha: https://github.com/stellar/stellar-protocol/blob/ae300437d15c1653eaefa1341ec829045c49a22f/core/cap-0046-01.md?plain=1#L257

Shaptic · 2026-08-06T23:40:01Z

+  [`docs/XDR_MIGRATION.md`](./docs/XDR_MIGRATION.md) covers every change with before/after examples and a quick-reference table.
+
+* Rebuilding the XDR layer changed a few SDK-level behaviors that don't involve typing `xdr.` yourself. Most of these fail silently, so they won't surface as compile errors ([#1422](https://github.com/stellar/js-stellar-sdk/pull/1422)):
+  * `scValToNative` returns a `Uint8Array` for an `scvString` / `scvSymbol` whose contents aren't valid UTF-8. It previously always returned a string, substituting U+FFFD — its byte-returning branch was unreachable. Guards like `typeof result === "string"` and calls like `result.startsWith(...)` are now data-dependent. The same applies to `contract.Spec#scValToNative` and `#funcResToNative` for `Bytes` / `BytesN`, which return `Uint8Array`; those are generically typed, so TypeScript won't flag it.


It'd be cool and easy to link each of these methods to its docs URL since AI can prolly one-shot that. Not a blocker by any means but could be an easy readability win.

Shaptic · 2026-08-06T23:40:34Z

+
+* Rebuilding the XDR layer changed a few SDK-level behaviors that don't involve typing `xdr.` yourself. Most of these fail silently, so they won't surface as compile errors ([#1422](https://github.com/stellar/js-stellar-sdk/pull/1422)):
+  * `scValToNative` returns a `Uint8Array` for an `scvString` / `scvSymbol` whose contents aren't valid UTF-8. It previously always returned a string, substituting U+FFFD — its byte-returning branch was unreachable. Guards like `typeof result === "string"` and calls like `result.startsWith(...)` are now data-dependent. The same applies to `contract.Spec#scValToNative` and `#funcResToNative` for `Bytes` / `BytesN`, which return `Uint8Array`; those are generically typed, so TypeScript won't flag it.
+  * `Operation.fromXdrObject` decodes `manageData`'s `name`, `setOptions`'s `homeDomain`, and `revokeSponsorship`'s data-entry name as UTF-8 rather than ASCII. For any byte ≥ `0x80` the string differs (`[0xC3, 0xA9]` now decodes to `"é"`, was `"C)"`), so round-tripping a decoded name can produce different wire bytes.


Uhhhh don't like that.. why?

Uh well the scValToNative claim about strings and symbols is just wrong I checked js-base and its always fallen back to return bytes when the utf8 decode failed.

The manageData entry is also stale. The strings provided for this operation get validated to be ascii so its not possible to get that different wire bytes when round-tripping

Hmm okay fair enough, so it's just more correct in general

Shaptic · 2026-08-06T23:46:08Z

+  built on js-xdr v5. Affects anyone who reads or builds `xdr.*` values, plus
+  anyone calling `tx.toXDR()` or `TransactionBuilder.fromXDR()`, which were
+  renamed.
+- **[Uint8Array migration guide](/uint8array_migration/)** — `Buffer` →


nor this one

The link looks weird, but it is correct if you generate the docs and run them

Shaptic · 2026-08-06T23:48:34Z

+| ------------------ | ------------------ |
+| `UInt128Parts`     | `Uint128Parts`     |
+| `UInt256Parts`     | `Uint256Parts`     |
+| `ThresholdIndices` | `ThresholdIndexes` |


In an effort to conform to modern ts naming rules. FWIW the built in Uint8Array also uses this naming structure. The ThresholdIndices is one that I am genuinely confused on. Something in the old xdr-gen was manually changing it to this naming. The .x definitions spell it as ThresholdIndexes

Yeah I was only commenting on that one. Indices seems more grammatically correct which is why I was confused, but it should def just match .x lol

Shaptic · 2026-08-06T23:49:15Z

+| `SorobanAuthorizationEntries`                  | array of `SorobanAuthorizationEntry` | `xdr.SorobanAuthorizationEntry[]` |
+| `ScString`, `ScSymbol`, `String32`, `String64` | `XDRString`                          | `xdr.XdrString` (§ 11)            |
+| `SponsorshipDescriptor`                        | `undefined \| AccountId`             | `xdr.AccountId \| null` (§ 14)    |
+


Lotta these are kinda whack - what's wrong with ScVec and friends?

Its not that theres anything wrong with them they just mostly don't do anything as a type. You get more info knowing that its an array

Hmm yeah I guess so - too much indirection

Shaptic · 2026-08-06T23:50:57Z

+`new XdrLargeInt("u64", 1n << 64n)` throws a `RangeError`, as does a slice that
+doesn't fit its width (e.g. `new XdrLargeInt("u128", [0n, 2n ** 80n])`).
+
+### `XdrLargeInt` and `ScInt`


Have you seen stellar/js-stellar-base#809? I don't think we should have both of these at all.

socket-security · 2026-08-07T17:25:02Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@stellar/stellar-xdr-json@26.0.0
	@stellar/js-xdr@5.0.0-rc.1

View full report

…1629)

* fix(xdr): restore wide-int MIN_VALUE/MAX_VALUE statics * docs(memo): record Memo.text dropping plain array input * docs(migration): record the three byte-input narrowings * Updated docs and changelog

Ryang-21 added 7 commits July 23, 2026 11:19

fix(xdr): emit SEP-51 key type instead of Rust-escaped type_ (#1571)

c0fdb6e

build(xdr): regenerate xdr.json via docker from pinned stellar-xdr co…

5233dc5

…mmit (#1575)

feat(xdr): support CAP-83 empty tx set values and CAP-85 external exe…

cf0659b

…cutables (#1577) * build(xdr): fail the schema download instead of masking it in a pipe * feat(xdr): support CAP-83 and CAP-85 protocol values

Merge main into v17-feature-branch (#1579)

a25ca5e

github-project-automation Bot added this to DevX Jul 31, 2026

github-project-automation Bot moved this to Backlog (Not Ready) in DevX Jul 31, 2026

Ryang-21 and others added 11 commits July 31, 2026 13:31

chore: record main merge lost to squash of #1579

9a52d96

fix(xdr): bound decimal string length before BigInt parse in JSON dec…

5a6f76f

…ode (#1581) * fix(xdr): bound decimal string length before BigInt parse in json decode * refactor(xdr): name the digit-budget constants in bigint-parts

fix(xdr): restrict fromJson to SEP-0051 keys and reject unknown fields (

54e4662

#1582) * fix(xdr): restrict fromJson to SEP-51 keys and reject unknown fields * fix(test): correct horizon corpus fixture path so corpus tests run * test(xdr): add JSON round-trips for mainnet corpus values

fix(strkey): bound decodeCheck input length before base32 decode (#1583)

a4bc598

fix(xdr): reject AssetCode12 JSON codes shorter than 5 bytes (#1585)

b7bf681

fix(horizon)!: make TransactionFailedExtras result_codes.operations o…

5888209

…ptional (#1586)

Fix: signed payload strkey framing (#1588)

8c5aed6

* fix(strkey): validate signed payload framing in decodeCheck * docs: regenerate core-keys source line references * test(strkey): cover SEP-23 signed payload invalid vectors * docs(changelog): note signed payload strkey framing validation

test(xdr): decode a forged 101-op transaction instead of reading maxL…

4b81e0c

…ength (#1591)

Ryang-21 requested a review from quietbits August 5, 2026 18:11

Ryang-21 marked this pull request as ready for review August 5, 2026 18:11

Copilot AI balanced review requested due to automatic review settings August 5, 2026 18:11

Copilot AI reviewed Aug 5, 2026

quietbits approved these changes Aug 5, 2026

View reviewed changes

Ryang-21 and others added 5 commits August 5, 2026 16:52

docs(xdr): clarify that the utf-8 decode change affects no valid oper…

5f148de

…ation

docs(xdr): fix MuxedAccount#setId example and add a staleness check r…

4ea82c0

…ecipe

fix(spec): restore instanceof Map check lost in the v17 merge

9159189

feat(xdr): add validateXdr static to every generated type (#1597)

0853c39

* feat(xdr): add validateXdr static to every generated type * docs(xdr): file validateXdr under renames, not removals

test(browser): stop the unit suite losing its page mid-run (#1596)

34bedce

Shaptic reviewed Aug 6, 2026

View reviewed changes

Ryang-21 added 2 commits August 7, 2026 10:16

docs(migration): tighten prose and normalize method references

6b70835

docs(changelog): apply pr review feedback to v17 entries

f735704

quietbits and others added 5 commits August 10, 2026 18:47

fix(contract): declare error classes, make types self-contained (#1627)

290a5d8

perf(strkey): reject by length and prefix before decodeCheck throws (#…

f4a91b2

…1629)

fix: restore wide-int bounds statics, document Memo.text break (#1628)

6562185

* fix(xdr): restore wide-int MIN_VALUE/MAX_VALUE statics * docs(memo): record Memo.text dropping plain array input * docs(migration): record the three byte-input narrowings * Updated docs and changelog

docs(changelog): scope the non-utf8 scvaltonative note to scvstring

2f7e8a9

docs(changelog): tighten the memo.text breaking-change entry

24d8cb4

Ryang-21 merged commit 1a6b117 into main Aug 10, 2026
16 checks passed

Ryang-21 deleted the v17-feature-branch branch August 10, 2026 23:43

github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Aug 10, 2026

Uh oh!

Conversation

Ryang-21 commented Jul 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ryang-21 Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

socket-security Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ryang-21 Aug 7, 2026 •

edited

Loading

socket-security Bot commented Aug 7, 2026 •

edited

Loading