Add link to cargo fetch_with_cli and clarify intent - #39
Merged
Conversation
leighmcculloch
marked this pull request as ready for review
July 16, 2026 02:36
leighmcculloch
enabled auto-merge (squash)
July 16, 2026 02:36
There was a problem hiding this comment.
Pull request overview
Adds a pinned Cargo source link and clarifies that Git environment sanitization is a correctness measure, not a security boundary.
Changes:
- Links to Cargo’s
fetch_with_cliimplementation. - Clarifies the intent of removing path-redirecting environment variables.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graydon
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a link to the cargo
fetch_with_clisource alongside the comment on thegit()helper, and add a note clarifying that stripping the path-redirectingGIT_*env vars is not a security measure against malicious injection but simply avoids ambient env vars that redirect git's path access to a different repository.Why
The comment referenced cargo's
fetch_with_clisanitization by name but gave no pointer to the actual code. A direct link makes the rationale easier to verify. The added note prevents a reader from misreading the env var stripping as a security boundary when it is only a correctness measure.