Skip to content

add socket tier 1 reachability analysis - #38

Merged
leighmcculloch merged 5 commits into
stellar:mainfrom
kanwalpreetd:main
Aug 24, 2026
Merged

add socket tier 1 reachability analysis#38
leighmcculloch merged 5 commits into
stellar:mainfrom
kanwalpreetd:main

Conversation

@kanwalpreetd

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings June 12, 2026 14:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7b1971715

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/socket-scan.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated GitHub Actions workflow to run Socket’s “Tier 1 reachability” analysis for this Rust crate on a weekly schedule and via manual dispatch, surfacing Tier 2 fallbacks as a non-failing GitHub Actions warning.

Changes:

  • Introduces a new scheduled + workflow_dispatch Socket reachability scan workflow.
  • Installs Rust + Node toolchains and the Socket CLI, then runs socket scan create --reach.
  • Post-processes scan output to emit a ::warning:: annotation when Tier 2 fallback markers are detected.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/socket-scan.yml Outdated
Comment thread .github/workflows/socket-scan.yml
Comment thread .github/workflows/socket-scan.yml Outdated
Comment thread .github/workflows/socket-scan.yml
kanwalpreetd and others added 4 commits June 29, 2026 02:15
- Make the Node 24 env-var comment date-agnostic (2026-06-16 has passed)
- Remove the unused Corepack step; this repo has no package.json, so it
  only ever shimmed yarn/pnpm that are never invoked
- Replace dtolnay/rust-toolchain with `rustup update`, matching the
  convention in this repo's other Rust workflows and dropping a
  third-party action from a security workflow

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
It is now dead config, for two independent reasons:

- Every action pinned in this workflow already declares `using: node24`
  in its action.yml, and the var only upgrades actions that declare
  node20 — so it had no effect here even before the cutover.
- GitHub runners have defaulted to Node 24 since 2026-06-16, and Node 20
  is fully removed on 2026-09-16.

Note the var never silenced the node20 deprecation warnings either: the
runner classifies an action from its declared version before consulting
this var (actions/runner#4295).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
leighmcculloch

This comment was marked as resolved.

@leighmcculloch
leighmcculloch enabled auto-merge (squash) August 24, 2026 04:26
@leighmcculloch
leighmcculloch merged commit fa66aae into stellar:main Aug 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants