add socket tier 1 reachability analysis - #38
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7b1971715
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow to run Socket’s “Tier 1 reachability” analysis for this Rust crate on a weekly schedule and via manual dispatch, surfacing Tier 2 fallbacks as a non-failing GitHub Actions warning.
Changes:
- Introduces a new scheduled + workflow_dispatch Socket reachability scan workflow.
- Installs Rust + Node toolchains and the Socket CLI, then runs
socket scan create --reach. - Post-processes scan output to emit a
::warning::annotation when Tier 2 fallback markers are detected.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Make the Node 24 env-var comment date-agnostic (2026-06-16 has passed) - Remove the unused Corepack step; this repo has no package.json, so it only ever shimmed yarn/pnpm that are never invoked - Replace dtolnay/rust-toolchain with `rustup update`, matching the convention in this repo's other Rust workflows and dropping a third-party action from a security workflow Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
It is now dead config, for two independent reasons: - Every action pinned in this workflow already declares `using: node24` in its action.yml, and the var only upgrades actions that declare node20 — so it had no effect here even before the cutover. - GitHub runners have defaulted to Node 24 since 2026-06-16, and Node 20 is fully removed on 2026-09-16. Note the var never silenced the node20 deprecation warnings either: the runner classifies an action from its declared version before consulting this var (actions/runner#4295). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
More info: https://stellarorg.atlassian.net/wiki/spaces/SCRT/pages/5689311233/Socket+Tier+1+Reachability+Analysis