Add optional profile-based Codex account discovery#631
Open
igneous-prose wants to merge 2 commits intosteipete:mainfrom
Open
Add optional profile-based Codex account discovery#631igneous-prose wants to merge 2 commits intosteipete:mainfrom
igneous-prose wants to merge 2 commits intosteipete:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fb5b99ba6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
This is a very useful feature; I desperately need it. |
igneous-prose
force-pushed
the
codex/profile-discovery-source
branch
from
2945970 to
db909ec
Compare
igneous-prose
force-pushed
the
codex/profile-discovery-source
branch
from
db909ec to
d72d5a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complements the managed Codex account flow added in 0.20.0-beta.1 by adding an advanced live-system account source based on already-signed-in local Codex profiles. Managed accounts remain the default path; this only affects Codex when the user explicitly selects a discovered local profile. Follow-up to #630.
This is an advanced optional path for users who already manage multiple Codex identities locally; it does not replace or broaden the managed-account model.
Testing
env CLANG_MODULE_CACHE_PATH=.build/clang-module-cache SWIFT_DRIVER_SWIFT_FRONTEND_MODULECACHE_PATH=.build/swiftpm-module-cache swift test --filter CodexProfileStoreTestsenv CLANG_MODULE_CACHE_PATH=.build/clang-module-cache SWIFT_DRIVER_SWIFT_FRONTEND_MODULECACHE_PATH=.build/swiftpm-module-cache swift test --filter CodexProfileRoutingTestsenv CLANG_MODULE_CACHE_PATH=.build/clang-module-cache SWIFT_DRIVER_SWIFT_FRONTEND_MODULECACHE_PATH=.build/swiftpm-module-cache swift test --filter CodexAccountsSettingsSectionTestsenv CLANG_MODULE_CACHE_PATH=.build/clang-module-cache SWIFT_DRIVER_SWIFT_FRONTEND_MODULECACHE_PATH=.build/swiftpm-module-cache swift test --filter StatusMenuCodexSwitcherTests