Skip to content

Improve I2C operations #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve I2C operations #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f08c8
Fix NuGets
josesimoes Jun 26, 2020
837959a
Add error handling to I2C operations (WIP)
josesimoes Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/AbstractIO.AdafruitMotorShieldV2/AbstractIO.AdafruitMotorShieldV2.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<Private>True</Private>
<SpecificVersion>True</SpecificVersion>
</Reference>
<Reference Include="Windows.Devices.Pwm, Version=1.5.1.2, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<Reference Include="Windows.Devices.Pwm, Version=1.5.1.3, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Windows.Devices.Pwm.1.5.1\lib\Windows.Devices.Pwm.dll</HintPath>
<Private>True</Private>
<SpecificVersion>True</SpecificVersion>
Expand Down
29 changes: 25 additions & 4 deletions source/AbstractIO.AdafruitMotorShieldV2/Pca9685PwmController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,12 @@ private void WriteRegister(byte registerOffset, byte data)
byte[] writeBuffer = { registerOffset, data };
lock (AbstractIO.GlobalLockObjects.I2cLockObject)
{
_i2cDevice.Write(writeBuffer);
var operationResult = _i2cDevice.WritePartial(writeBuffer);
if(operationResult.Status != I2cTransferStatus.FullTransfer)
{
// TODO
// handle error
}
}
}

Expand All @@ -202,7 +207,12 @@ private void WriteConsecutiveRegisters(byte startRegisterOffset, params byte[] v
}
lock (AbstractIO.GlobalLockObjects.I2cLockObject)
{
_i2cDevice.Write(writeBuffer);
var operationResult = _i2cDevice.WritePartial(writeBuffer);
if (operationResult.Status != I2cTransferStatus.FullTransfer)
{
// TODO
// handle error
}
}
}

Expand Down Expand Up @@ -272,8 +282,19 @@ private byte ReadRegister(byte registerOffset)
var readBuffer = new byte[1];
lock (AbstractIO.GlobalLockObjects.I2cLockObject)
{
_i2cDevice.Write(writeBuffer);
_i2cDevice.Read(readBuffer);
var operationResult = _i2cDevice.WritePartial(writeBuffer);
if (operationResult.Status != I2cTransferStatus.FullTransfer)
{
// TODO
// handle error
}

operationResult = _i2cDevice.ReadPartial(readBuffer);
if (operationResult.Status != I2cTransferStatus.FullTransfer)
{
// TODO
// handle error
}
}
return readBuffer[0];
}
Expand Down
2 changes: 1 addition & 1 deletion source/AbstractIO.Netduino3/AbstractIO.Netduino3.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<Private>True</Private>
<SpecificVersion>True</SpecificVersion>
</Reference>
<Reference Include="Windows.Devices.Pwm, Version=1.5.1.2, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<Reference Include="Windows.Devices.Pwm, Version=1.5.1.3, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Windows.Devices.Pwm.1.5.1\lib\Windows.Devices.Pwm.dll</HintPath>
<Private>True</Private>
<SpecificVersion>True</SpecificVersion>
Expand Down