-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add ndarray/splice
#9807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: add ndarray/splice
#9807
Changes from all commits
262aa22
8a9d371
47bdee4
da84b57
9087edf
61d6661
847b074
7fabd48
e3a4705
f1886b4
d6940a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,170 @@ | ||||||
| <!-- | ||||||
|
|
||||||
| @license Apache-2.0 | ||||||
|
|
||||||
| Copyright (c) 2026 The Stdlib Authors. | ||||||
|
|
||||||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
| you may not use this file except in compliance with the License. | ||||||
| You may obtain a copy of the License at | ||||||
|
|
||||||
| http://www.apache.org/licenses/LICENSE-2.0 | ||||||
|
|
||||||
| Unless required by applicable law or agreed to in writing, software | ||||||
| distributed under the License is distributed on an "AS IS" BASIS, | ||||||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
| See the License for the specific language governing permissions and | ||||||
| limitations under the License. | ||||||
|
|
||||||
| --> | ||||||
|
|
||||||
| # splice | ||||||
|
|
||||||
| > Return an [`ndarray`][@stdlib/ndarray/ctor] where elements of an input [`ndarray`][@stdlib/ndarray/ctor] are replaced or removed along a specific dimension. | ||||||
|
|
||||||
| <!-- Section to include introductory text. Make sure to keep an empty line after the intro `section` element and another before the `/section` close. --> | ||||||
|
|
||||||
| <section class="intro"> | ||||||
|
|
||||||
| </section> | ||||||
|
|
||||||
| <!-- /.intro --> | ||||||
|
|
||||||
| <!-- Package usage documentation. --> | ||||||
|
|
||||||
| <section class="usage"> | ||||||
|
|
||||||
| ## Usage | ||||||
|
|
||||||
| ```javascript | ||||||
| var splice = require( '@stdlib/ndarray/splice' ); | ||||||
| ``` | ||||||
|
|
||||||
| #### splice( x, slices\[, values\[, options]] ) | ||||||
|
|
||||||
| Returns an [`ndarray`][@stdlib/ndarray/ctor] where elements of an input [`ndarray`][@stdlib/ndarray/ctor] are replaced or removed along a specific dimension. | ||||||
|
|
||||||
| ```javascript | ||||||
| var Slice = require( '@stdlib/slice/ctor' ); | ||||||
| var array = require( '@stdlib/ndarray/array' ); | ||||||
|
|
||||||
| var x = array( [ [ 1.0, 2.0 ], [ 3.0, 4.0 ], [ 5.0, 6.0 ] ] ); | ||||||
| // returns <ndarray>[ [ 1.0, 2.0 ], [ 3.0, 4.0 ], [ 5.0, 6.0 ] ] | ||||||
|
|
||||||
| var y = array( [ [ 20.0 ], [ 40.0 ], [ 60.0 ] ] ); | ||||||
| // returns <ndarray>[ [ 20.0 ], [ 40.0 ], [ 60.0 ] ] | ||||||
|
|
||||||
| var s = new Slice( 1, null, 1 ); | ||||||
| // returns <Slice> | ||||||
|
|
||||||
| var out = splice( x, s, y ); | ||||||
| // returns <ndarray>[ [ 1.0, 20.0 ], [ 3.0, 40.0 ], [ 5.0, 60.0 ] ] | ||||||
| ``` | ||||||
|
|
||||||
| The function accepts the following arguments: | ||||||
|
|
||||||
| - **x**: input [`ndarray`][@stdlib/ndarray/ctor]. | ||||||
| - **slices**: a [`Slice`][@stdlib/slice/ctor] instance, `null`, `undefined`, an integer, or an array of such values. If provided `null` or `undefined`, the argument is equivalent to `new Slice()` (i.e., the returned view should include all elements along a specified dimension). If provided an integer less than zero, the corresponding element along the specified dimension is resolved relative to the last element along that dimension. For negative integers, the last element corresponds to the value `-1`. | ||||||
| - **values**: an [`ndarray`][@stdlib/ndarray/ctor] or an array of [`ndarrays`][@stdlib/ndarray/ctor] containing the elements to insert. The provided [`ndarrays`][@stdlib/ndarray/ctor] must be [broadcast compatible][@stdlib/ndarray/base/broadcast-shapes] with the slice region (_optional_). | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should be more explicit in terms of what we mean by being broadcast compatible with the slice region. I believe we mean to say that each ndarray must be broadcast compatible with the shape of the input ndarray except for the dimension defined by Furthermore, similar to
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably also state somewhere that each So, in short, you need to be validating that the number of dimensions in each |
||||||
| - **options**: function options (_optional_). | ||||||
|
|
||||||
| The function accepts the following `options`: | ||||||
|
|
||||||
| - **dim**: dimension along which to perform the operation. The index is resolved relative to the last dimension, with the last dimension corresponding to the value `-1`. Default: `-1`. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Use language consistent with other packages. This is a common review comment.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, I don't believe we need to restrict |
||||||
|
|
||||||
| By default, the function performs the operation on the last dimension. To perform the operation on any other dimension, specify the `dim` option. | ||||||
|
|
||||||
| ```javascript | ||||||
| var Slice = require( '@stdlib/slice/ctor' ); | ||||||
| var array = require( '@stdlib/ndarray/array' ); | ||||||
|
|
||||||
| var x = array( [ [ 1.0, 2.0 ], [ 3.0, 4.0 ], [ 5.0, 6.0 ] ] ); | ||||||
| // returns <ndarray>[ [ 1.0, 2.0 ], [ 3.0, 4.0 ], [ 5.0, 6.0 ] ] | ||||||
|
|
||||||
| var y = array( [ [ 10.0, 20.0 ] ] ); | ||||||
| // returns <ndarray>[ [ 10.0, 20.0 ] ] | ||||||
|
|
||||||
| var s = new Slice( 1, 2, 1 ); | ||||||
| // returns <Slice> | ||||||
|
|
||||||
| var out = splice( x, s, y, { | ||||||
| 'dim': -2 | ||||||
| }); | ||||||
| // returns <ndarray>[ [ 1.0, 2.0 ], [ 10.0, 20.0 ], [ 5.0, 6.0 ] ] | ||||||
| ``` | ||||||
|
|
||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reading this documentation, you have omitted examples showing the various call signatures which may be of interest. For example, in none of the examples do you show how you can perform multiple splices (including multiple removals, multiple insertions, etc). Nor do you show an example using broadcasting. Nor do you show how you can use If all I knew was what the docs currently show, I would have little idea of the full capabilities of this API. I suggest thinking more from the reader's point of view and providing more examples showcasing all the things this API can do. This API is quite powerful, and your current docs fail to capture that. |
||||||
| </section> | ||||||
|
|
||||||
| <!-- /.usage --> | ||||||
|
|
||||||
| <!-- Package usage notes. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||||||
|
|
||||||
| <section class="notes"> | ||||||
|
|
||||||
| </section> | ||||||
|
|
||||||
| <!-- /.notes --> | ||||||
|
|
||||||
| <!-- Package usage examples. --> | ||||||
|
|
||||||
| <section class="examples"> | ||||||
|
|
||||||
| ## Examples | ||||||
|
|
||||||
| ```javascript | ||||||
| var uniform = require( '@stdlib/random/uniform' ); | ||||||
| var ndarray2array = require( '@stdlib/ndarray/to-array' ); | ||||||
| var Slice = require( '@stdlib/slice/ctor' ); | ||||||
| var splice = require( '@stdlib/ndarray/splice' ); | ||||||
|
|
||||||
| var x = uniform( [ 3, 3, 3 ], -10, 10 ); | ||||||
| console.log( ndarray2array( x ) ); | ||||||
|
|
||||||
| var s = new Slice( 1, 2, 1 ); | ||||||
|
|
||||||
| var y = uniform( [ 1, 3, 3 ], 20, 40 ); | ||||||
| console.log( 'Values: ', ndarray2array( y ) ); | ||||||
|
|
||||||
| var out = splice( x, s, y, { | ||||||
| 'dim': -3 | ||||||
| }); | ||||||
| console.log( ndarray2array( out ) ); | ||||||
| ``` | ||||||
|
|
||||||
| </section> | ||||||
|
|
||||||
| <!-- /.examples --> | ||||||
|
|
||||||
| <!-- Section to include cited references. If references are included, add a horizontal rule *before* the section. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||||||
|
|
||||||
| <section class="references"> | ||||||
|
|
||||||
| </section> | ||||||
|
|
||||||
| <!-- /.references --> | ||||||
|
|
||||||
| <!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. --> | ||||||
|
|
||||||
| <section class="related"> | ||||||
|
|
||||||
| </section> | ||||||
|
|
||||||
| <!-- /.related --> | ||||||
|
|
||||||
| <!-- Section for all links. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||||||
|
|
||||||
| <section class="links"> | ||||||
|
|
||||||
| [@stdlib/slice/ctor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/slice/ctor | ||||||
|
|
||||||
| [@stdlib/ndarray/ctor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/ndarray/ctor | ||||||
|
|
||||||
| [@stdlib/ndarray/base/broadcast-shapes]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/ndarray/base/broadcast-shapes | ||||||
|
|
||||||
| <!-- <related-links> --> | ||||||
|
|
||||||
| <!-- </related-links> --> | ||||||
|
|
||||||
| </section> | ||||||
|
|
||||||
| <!-- /.links --> | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapted from https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/blas/ext/index-of.