refactor: align parameter names with sibling packages#12493
Merged
Conversation
Contributor
Coverage ReportNo coverage information available. |
5a36168 to
9b1efb4
Compare
strided/snanmaxabsstrided/snanmaxabs
kgryte
approved these changes
Jun 3, 2026
strided/snanmaxabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request renames the
stride/offsetparameters tostrideX/offsetX(signatures and@paramcomments) for consistency withsnanmaxand the modern strided declaration convention. Parameter names do not affect type-checking.This is part of a series of follow-up PRs addressing findings from a TypeScript declaration audit of the
statsnamespace (documentation-only fixes landed separately in #12482).Related Issues
No.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This change was surfaced by a Claude Code audit of the
statsnamespace TypeScript declarations. The fix was verified against the implementation and declaration test before submission, and reviewed by myself.@stdlib-js/reviewers