Skip to content

refactor: align parameter names with sibling packages#12493

Merged
kgryte merged 1 commit into
developfrom
philipp/strided-snanmaxabs-param-names
Jun 3, 2026
Merged

refactor: align parameter names with sibling packages#12493
kgryte merged 1 commit into
developfrom
philipp/strided-snanmaxabs-param-names

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request renames the stride/offset parameters to strideX/offsetX (signatures and @param comments) for consistency with snanmax and the modern strided declaration convention. Parameter names do not affect type-checking.

This is part of a series of follow-up PRs addressing findings from a TypeScript declaration audit of the stats namespace (documentation-only fixes landed separately in #12482).

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This change was surfaced by a Claude Code audit of the stats namespace TypeScript declarations. The fix was verified against the implementation and declaration test before submission, and reviewed by myself.


@stdlib-js/reviewers

@Planeshifter Planeshifter requested a review from a team June 3, 2026 05:05
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jun 3, 2026

Coverage Report

No coverage information available.

@Planeshifter Planeshifter marked this pull request as draft June 3, 2026 05:22
@Planeshifter Planeshifter force-pushed the philipp/strided-snanmaxabs-param-names branch from 5a36168 to 9b1efb4 Compare June 3, 2026 05:26
@Planeshifter Planeshifter changed the title fix: align parameter names with siblings in strided/snanmaxabs refactor: align parameter names with siblings in strided/snanmaxabs Jun 3, 2026
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jun 3, 2026
@kgryte kgryte marked this pull request as ready for review June 3, 2026 07:19
@kgryte kgryte changed the title refactor: align parameter names with siblings in strided/snanmaxabs refactor: align parameter names with sibling packages Jun 3, 2026
@kgryte kgryte merged commit db6c193 into develop Jun 3, 2026
52 checks passed
@kgryte kgryte deleted the philipp/strided-snanmaxabs-param-names branch June 3, 2026 07:19
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants