chore: address follow-up review findings for commits merged to develop on 2026-05-31#12430
Merged
Merged
Conversation
The JSDoc and TypeScript declaration both promise to return the workspace array, but the `N === 1` short-circuit returned `undefined`, breaking the documented `out === workspace` contract.
…ay/isamax` The benchmark guarded the integer index return value with `isnanf`, which is the float32 NaN predicate; switch to `isnan` to match the documented integer return type and the sibling `igamax` benchmark. Also drop the spurious `.0` from the TypeScript example, since the function returns an integer index.
…e/ndarray` The newly added `idamax` and `isamax` JSDoc examples in the namespace declarations documented the return value as `4.0`, but both routines return an integer index. Match the `igamax` entry, which already used `returns 4`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
develop on 2026-05-31develop on 2026-05-31
7 tasks
develop on 2026-05-31develop on 2026-05-31
Member
Author
|
Probably okay to use "chore:" even though a touched file is a "fix:", given how the package just landed and is unpublished. |
kgryte
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetweenafb44ae(2026-05-31 15:54 -0500) andd2f751e(2026-06-01 04:32 -0700).Description
This pull request:
rfftito return the workspace array whenN === 1(62ee5f8,lib/node_modules/@stdlib/fft/base/fftpack/rffti/lib/main.js); the early-exit branch silently returnedundefined, violating the documented return contract and breaking reference equality with the caller's workspace.lib/node_modules/@stdlib/blas/base/ndarray/igamax/lib/index.js(1d9f9d1) to match every other BLAS ndarray package.is-nanfwithis-naninlib/node_modules/@stdlib/blas/base/ndarray/isamax/benchmark/benchmark.js(4302ca2);isamaxreturns an integer index, and the siblingigamaxbenchmark already usesis-nan..0from theisamaxJSDoc example inlib/node_modules/@stdlib/blas/base/ndarray/isamax/docs/types/index.d.ts(4302ca2); the return value is an integer index..0from theidamaxandisamaxJSDoc examples inlib/node_modules/@stdlib/blas/base/ndarray/docs/types/index.d.ts(52ca9a6); both routines return an integer index, consistent with theigamaxentry already in the same file.Related Issues
No.
Questions
No.
Other
Validation audit:
docs/style-guides/) and bug scan across the union diff of all first-parent commits merged todevelopin the trailing 24-hour window.// returns 4.0inlib/node_modules/@stdlib/blas/base/ndarray/idamax/docs/types/index.d.ts(out of window).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code: a sonnet summarizer agent extracted author intent for the 36 commits in window, two sonnet style-compliance agents and two opus bug-scan agents reviewed the union diff in parallel, and findings reported by a single agent were independently re-verified against the diff before being applied. Only high-signal issues survived filtering. A maintainer should audit before promoting from draft.
@stdlib-js/reviewers
Generated by Claude Code