Skip to content

style: use explicit float literal in stats/base/dists/gumbel/cdf#12379

Merged
kgryte merged 1 commit into
developfrom
philipp/drift-stats-base-dists-gumbel-2026-05-30
May 30, 2026
Merged

style: use explicit float literal in stats/base/dists/gumbel/cdf#12379
kgryte merged 1 commit into
developfrom
philipp/drift-stats-base-dists-gumbel-2026-05-30

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

This pull request:

  • Changes the beta validation predicate in stats/base/dists/gumbel/cdf/lib/factory.js from beta <= 0 to beta <= 0.0, matching the convention used in the other 19 such comparisons across stats/base/dists/gumbel/*/lib/{main,factory}.js (95% conformance). Numerically equivalent in JavaScript; the change is purely stylistic.

stats/base/dists/gumbel/cdf

The factory's nonpositive-beta guard used the bare integer literal 0. Every other beta <= 0.0 check in the namespace (19 occurrences across main.js and factory.js of the remaining 14 packages, plus the package's own lib/main.js) uses the explicit float form. One-line normalization to bring this file in line with its siblings.

Related Issues

No.

Questions

No.

Other

No.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude (Anthropic) running a cross-package drift-detection routine. The change was identified by automated structural analysis across the stats/base/dists/gumbel namespace and validated against tests and sibling packages before being applied.


@stdlib-js/reviewers


Generated by Claude Code

…ts/gumbel/cdf/lib/factory.js`

Aligns the validation predicate with the namespace convention.
Previously the only occurrence in `stats/base/dists/gumbel` using bare
`beta <= 0`; all 19 other comparisons across the namespace's
`lib/main.js` and `lib/factory.js` files use `beta <= 0.0` (95%
conformance). Numerically equivalent in JavaScript; change is purely
stylistic.
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label May 30, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gumbel/cdf $\color{green}293/293$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}293/293$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review May 30, 2026 20:37
@kgryte kgryte requested a review from a team May 30, 2026 20:37
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. labels May 30, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 30, 2026
@kgryte kgryte changed the title style: use explicit float literal in stats/base/dists/gumbel/cdf factory style: use explicit float literal in stats/base/dists/gumbel/cdf May 30, 2026
@kgryte kgryte merged commit faef343 into develop May 30, 2026
70 checks passed
@kgryte kgryte deleted the philipp/drift-stats-base-dists-gumbel-2026-05-30 branch May 30, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants