style: use explicit float literal in stats/base/dists/gumbel/cdf#12379
Merged
Conversation
…ts/gumbel/cdf/lib/factory.js` Aligns the validation predicate with the namespace convention. Previously the only occurrence in `stats/base/dists/gumbel` using bare `beta <= 0`; all 19 other comparisons across the namespace's `lib/main.js` and `lib/factory.js` files use `beta <= 0.0` (95% conformance). Numerically equivalent in JavaScript; change is purely stylistic.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
May 30, 2026
stats/base/dists/gumbel/cdf factorystats/base/dists/gumbel/cdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
betavalidation predicate instats/base/dists/gumbel/cdf/lib/factory.jsfrombeta <= 0tobeta <= 0.0, matching the convention used in the other 19 such comparisons acrossstats/base/dists/gumbel/*/lib/{main,factory}.js(95% conformance). Numerically equivalent in JavaScript; the change is purely stylistic.stats/base/dists/gumbel/cdfThe factory's nonpositive-
betaguard used the bare integer literal0. Every otherbeta <= 0.0check in the namespace (19 occurrences acrossmain.jsandfactory.jsof the remaining 14 packages, plus the package's ownlib/main.js) uses the explicit float form. One-line normalization to bring this file in line with its siblings.Related Issues
No.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude (Anthropic) running a cross-package drift-detection routine. The change was identified by automated structural analysis across the
stats/base/dists/gumbelnamespace and validated against tests and sibling packages before being applied.@stdlib-js/reviewers
Generated by Claude Code