Skip to content

feat: add blas/ext/base/dcombinations#10847

Open
headlessNode wants to merge 10 commits into
stdlib-js:developfrom
headlessNode:dcomb
Open

feat: add blas/ext/base/dcombinations#10847
headlessNode wants to merge 10 commits into
stdlib-js:developfrom
headlessNode:dcomb

Conversation

@headlessNode
Copy link
Copy Markdown
Member

@headlessNode headlessNode commented Mar 9, 2026

Resolves stdlib-js/metr-issue-tracker#175.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/dcombinations

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code with a little fixes(mostly style related) manually.

@stdlib-js/reviewers

@headlessNode
feat: add blas/ext/base/dcombinations
a618d43 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode
fix: apply suggestions from code review
b5d5cf6 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 9, 2026
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. and removed BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Mar 9, 2026
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 9, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 9, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dcombinations $\color{green}647/647$
$\color{green}+0.00\%$ 		$\color{green}81/81$
$\color{green}+0.00\%$ 		$\color{green}6/6$
$\color{green}+0.00\%$ 		$\color{green}647/647$
$\color{green}+0.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode
refactor: apply suggestions from code review
4b2a871 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode
fix: add early guards in js native
52fdc0a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode marked this pull request as ready for review March 11, 2026 20:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 11, 2026
@headlessNode headlessNode requested a review from kgryte March 11, 2026 20:29
kgryte
kgryte reviewed May 28, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dcombinations/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed May 28, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dcombinations/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed May 28, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dcombinations/lib/ndarray.js Outdated
kgryte
kgryte requested changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels May 28, 2026
@headlessNode headlessNode requested a review from a team May 29, 2026 17:32
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 29, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 29, 2026
@headlessNode
fix: apply suggestions from code review
7f6e260 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode requested a review from kgryte June 1, 2026 18:17
@headlessNode headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Jun 1, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 1, 2026
@headlessNode
Copy link
Copy Markdown
Member Author

headlessNode commented Jun 1, 2026

@kgryte I ended up adding the workspace here since using out for that purpose didn't make sense to me here.

kgryte
kgryte reviewed Jun 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dcombinations/lib/ndarray.js Outdated
kgryte
kgryte reviewed Jun 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dcombinations/lib/ndarray.js Outdated
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 2, 2026
headlessNode and others added 2 commits June 3, 2026 21:19
@headlessNode
Merge branch 'develop' into dcomb
97bae04
@headlessNode
refactor: apply suggestions from code review
204d0eb 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Jun 4, 2026
@headlessNode headlessNode requested a review from kgryte June 4, 2026 18:29
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte Awaiting requested review from kgryte

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/dcombinations

3 participants

@headlessNode @stdlib-bot @kgryte