Skip to content

feat: add ml/base/kmeans/metric-str2enum#10842

Merged
kgryte merged 4 commits into
stdlib-js:developfrom
nakul-krishnakumar:kmeans-metric-str2enum
May 27, 2026
Merged

feat: add ml/base/kmeans/metric-str2enum#10842
kgryte merged 4 commits into
stdlib-js:developfrom
nakul-krishnakumar:kmeans-metric-str2enum

Conversation

@nakul-krishnakumar
Copy link
Copy Markdown
Member

@nakul-krishnakumar nakul-krishnakumar commented Mar 9, 2026

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • Adds ml/base/kmeans/metric-str2enum.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

None.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 9, 2026
@nakul-krishnakumar
Copy link
Copy Markdown
Member Author

This PR is blocked by #10714 and in cyclic dependency with #10841

@kgryte kgryte requested a review from a team May 27, 2026 08:37
@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 27, 2026

@nakul-krishnakumar Looks like you'll want to move this package.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Machine Learning Issue or pull request specific to machine learning functionality. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels May 27, 2026
@nakul-krishnakumar
Copy link
Copy Markdown
Member Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 27, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 27, 2026
@nakul-krishnakumar
Copy link
Copy Markdown
Member Author

nakul-krishnakumar commented May 27, 2026

@kgryte I have moved the package, but the test shows error as ml/base/kmeans/metric-enum2str is still not merged. Should I move that package too into this PR (there is a cyclic dependency) or can we just avoid the error and merge it?

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label May 27, 2026
@kgryte kgryte changed the title feat: add ml/base/cluster/kmeans/metric-str2enum feat: add ml/base/kmeans/metric-str2enum May 27, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 27, 2026

As the CI failure is expected, I'll go ahead and merge.

@kgryte kgryte merged commit 0447203 into stdlib-js:develop May 27, 2026
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Machine Learning Issue or pull request specific to machine learning functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants