chore: tidy up injection of token manager dependency into communities… #6944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (6)
|
igor-sirotin
approved these changes
Sep 19, 2025
dlipicar
force-pushed
the
chore/improve-messenger-dependency-injection
branch
from
acf6074 to
da42aef
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6944 +/- ##
===========================================
- Coverage 58.95% 58.93% -0.02%
===========================================
Files 822 823 +1
Lines 122002 122261 +259
===========================================
+ Hits 71921 72051 +130
- Misses 42649 42804 +155
+ Partials 7432 7406 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dlipicar
force-pushed
the
chore/improve-messenger-dependency-injection
branch
from
da42aef to
f3cfa41
Compare
jrainville
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… manager
Cleaner use of adapter pattern to inject the Wallet's Token Manager into the Communities manager
Creation of the adaptor objects is now in charge of the class that instantiates everything. Before it was inside the communities package, which meant communities had to import the wallet's packages even though it's only really interested in the interfaces it defines.
Split token list interface from token balance interface in preparation for future refactors.