Skip to content

chore: multi-transaction ID references removal #6939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2025
Merged

chore: multi-transaction ID references removal #6939

merged 3 commits into from
Sep 22, 2025

Conversation

saledjenic
Copy link
Contributor

  • Updated multiple services and tests to eliminate multi-transaction ID from SendTransactionWithSignature and related methods.
  • Eliminated multi-transaction ID from various structures and functions across the wallet service.
  • Adjusted transaction management logic across the code base.
  • Updated related queries and database interactions to reflect the removal of multi-transaction handling.
  • Cleaned up related tests.

@status-im-auto
Copy link
Member

status-im-auto commented Sep 18, 2025 •
edited
Loading

Jenkins Builds

Click to see older builds (21)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3b2cbe6 #1 2025-09-18 07:40:19 ~3 min linux/status-go 📦zip
✔️ 3b2cbe6 #1 2025-09-18 07:47:45 ~10 min linux/nwaku 📦zip
✔️ 704a7a8 #2 2025-09-18 07:40:35 ~2 min macos/status-go 📦zip
✔️ 704a7a8 #2 2025-09-18 07:41:36 ~3 min windows/status-go 📦zip
✔️ 704a7a8 #2 2025-09-18 07:43:34 ~3 min linux/status-go 📦zip
✔️ 704a7a8 #2 2025-09-18 07:47:15 ~9 min tests-rpc 📄log
✔️ 704a7a8 #2 2025-09-18 07:57:58 ~10 min linux/nwaku 📦zip
✔️ 704a7a8 #2 2025-09-18 08:02:53 ~25 min tests 📄log
✔️ a6e6598 #3 2025-09-18 08:43:19 ~3 min linux/status-go 📦zip
✔️ a6e6598 #3 2025-09-18 08:44:08 ~4 min macos/status-go 📦zip
✔️ a6e6598 #3 2025-09-18 08:44:47 ~4 min windows/status-go 📦zip
✔️ a6e6598 #3 2025-09-18 08:51:20 ~11 min linux/nwaku 📦zip
✖️ a6e6598 #3 2025-09-18 08:52:47 ~13 min tests-rpc 📄log
✔️ a6e6598 #3 2025-09-18 09:08:10 ~28 min tests 📄log
✔️ a6e6598 #4 2025-09-18 09:18:48 ~9 min tests-rpc 📄log
✔️ 08f0bcf #4 2025-09-18 09:33:28 ~4 min windows/status-go 📦zip
✔️ 08f0bcf #4 2025-09-18 09:33:38 ~4 min macos/status-go 📦zip
✔️ 08f0bcf #4 2025-09-18 09:40:30 ~11 min linux/status-go 📦zip
✔️ 08f0bcf #4 2025-09-18 09:48:08 ~19 min linux/nwaku 📦zip
✔️ 08f0bcf #5 2025-09-18 09:48:19 ~19 min tests-rpc 📄log
✔️ 08f0bcf #4 2025-09-18 10:05:29 ~36 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3cf7c82 #5 2025-09-18 13:24:17 ~4 min macos/status-go 📦zip
✔️ 3cf7c82 #5 2025-09-18 13:24:46 ~4 min windows/status-go 📦zip
✔️ 3cf7c82 #5 2025-09-18 13:49:01 ~29 min linux/status-go 📦zip
✔️ 3cf7c82 #5 2025-09-18 13:57:52 ~37 min linux/nwaku 📦zip
✔️ 3cf7c82 #6 2025-09-18 14:00:29 ~40 min tests-rpc 📄log
✔️ 3cf7c82 #5 2025-09-18 14:18:17 ~58 min tests 📄log
✔️ 8dd6a15 #6 2025-09-22 13:43:17 ~3 min linux/status-go 📦zip
✔️ 8dd6a15 #6 2025-09-22 13:43:24 ~3 min macos/status-go 📦zip
✔️ 8dd6a15 #6 2025-09-22 13:46:39 ~6 min windows/status-go 📦zip
✔️ 8dd6a15 #7 2025-09-22 13:50:02 ~10 min tests-rpc 📄log
✔️ 8dd6a15 #6 2025-09-22 13:50:55 ~10 min linux/nwaku 📦zip
✖️ 8dd6a15 #6 2025-09-22 14:07:29 ~27 min tests 📄log

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.74648% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.42%. Comparing base (9dc24da) to head (3cf7c82).

Files with missing lines Patch % Lines
services/wallet/transfer/downloader.go 0.00% 41 Missing ⚠️
transactions/pendingtxtracker.go 28.57% 5 Missing ⚠️
services/wallet/transfer/commands.go 0.00% 4 Missing ⚠️
services/wallet/transfer/testutils.go 86.95% 3 Missing ⚠️
...allet/router/pathprocessor/processor_bridge_hop.go 0.00% 2 Missing ⚠️
api/geth_backend.go 0.00% 1 Missing ⚠️
.../wallet/router/pathprocessor/nft_handler_erc721.go 0.00% 1 Missing ⚠️
...s/wallet/router/pathprocessor/processor_erc1155.go 0.00% 1 Missing ⚠️
services/wallet/transfer/transaction_manager.go 0.00% 1 Missing ⚠️
...vices/wallet/transfer/transaction_manager_route.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           chore/cleaning    #6939      +/-   ##
==================================================
+ Coverage           59.39%   59.42%   +0.02%     
==================================================
  Files                 817      817              
  Lines              120879   120841      -38     
==================================================
+ Hits                71801    71814      +13     
+ Misses              41681    41638      -43     
+ Partials             7397     7389       -8
Flag Coverage Δ
functional 31.53% <15.49%> (-0.01%) ⬇️
unit 55.56% <47.18%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/wallet/activity/common/types.go 100.00% <ø> (ø)
services/wallet/common/const.go 86.48% <ø> (ø)
...ervices/wallet/router/pathprocessor/nft_handler.go 71.42% <100.00%> (ø)
services/wallet/transfer/database.go 62.92% <100.00%> (+0.90%) ⬆️
services/wallet/transfer/query.go 63.84% <100.00%> (ø)
services/wallet/wallettypes/types.go 30.00% <ø> (ø)
transactions/transactor.go 64.21% <100.00%> (-0.10%) ⬇️
api/geth_backend.go 52.84% <0.00%> (ø)
.../wallet/router/pathprocessor/nft_handler_erc721.go 20.90% <0.00%> (ø)
...s/wallet/router/pathprocessor/processor_erc1155.go 3.84% <0.00%> (ø)
... and 7 more

... and 31 files with indirect coverage changes

@saledjenic saledjenic marked this pull request as ready for review September 18, 2025 08:06
@saledjenic saledjenic mentioned this pull request Sep 18, 2025
Open
dlipicar
dlipicar reviewed Sep 18, 2025
View reviewed changes
services/wallet/activity/common/types.go Outdated
PayloadType PayloadType `json:"payloadType"`
Key string `json:"key"`
Transaction *TransactionIdentity `json:"transaction,omitempty"`
Transactions []*TransactionIdentity `json:"transactions,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess Transactions is no longer used? It was only there for the MultiTransaction case if I remember correctly

@saledjenic
chore: simplify transaction handling by removing multi-transaction ID
059e02f 
- Updated multiple services and tests to eliminate multi-transaction ID from `SendTransactionWithSignature` and related methods.
- Adjusted transaction management logic across the code base.
- Cleaned up related tests.
@saledjenic
chore: remove multi-transaction ID references and clean up code
3cf7c82 
- Eliminated multi-transaction ID from various structures and functions across the wallet service.
- Updated related queries and database interactions to reflect the removal of multi-transaction handling.
- Cleaned up related tests.
@saledjenic
chore: remove unused methods from path processors
8dd6a15 
- Eliminated `Send` and `BuildTransaction` methods.
- Updated related tests to reflect the removal of these methods.
- Codebase cleaned up accordingly.
@saledjenic saledjenic merged commit c68dd95 into chore/cleaning Sep 22, 2025
2 of 10 checks passed
@saledjenic saledjenic deleted the chore/cleaning-1 branch September 22, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaibe alaibe alaibe approved these changes

@dlipicar dlipicar dlipicar approved these changes

@friofry friofry Awaiting requested review from friofry

@vkjr vkjr Awaiting requested review from vkjr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saledjenic @status-im-auto @alaibe @dlipicar